Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: tools/clang/plugins/FindBadConstructsConsumer.cpp

Issue 2490473007: Improved check for trivial templates. (Closed)
Patch Set: Check in Type::Typedef, and add a test expectations file. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/clang/plugins/tests/trivial_ctor.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/plugins/FindBadConstructsConsumer.cpp
diff --git a/tools/clang/plugins/FindBadConstructsConsumer.cpp b/tools/clang/plugins/FindBadConstructsConsumer.cpp
index 00d4cb9a2316e42dbffd147d21ce93e418c0b867..db8c472d8c96c8352fadcb55297c0817927e11e6 100644
--- a/tools/clang/plugins/FindBadConstructsConsumer.cpp
+++ b/tools/clang/plugins/FindBadConstructsConsumer.cpp
@@ -675,6 +675,11 @@ void FindBadConstructsConsumer::CountType(const Type* type,
}
case Type::Typedef: {
while (const TypedefType* TT = dyn_cast<TypedefType>(type)) {
+ const std::string name = TT->getDecl()->getNameAsString();
+ if (name == "atomic_int") {
dcheng 2016/11/10 00:41:03 Nit: I wonder if we should get the decl context an
+ (*trivial_member)++;
+ return;
+ }
type = TT->getDecl()->getUnderlyingType().getTypePtr();
}
CountType(type,
« no previous file with comments | « no previous file | tools/clang/plugins/tests/trivial_ctor.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698