Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Issue 2490473006: [Devtools] Network Now has 100ms minimum rather than 1s for timelines (Closed)

Created:
4 years, 1 month ago by allada
Modified:
4 years, 1 month ago
Reviewers:
paulirish, dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Network Now has 100ms minimum rather than 1s for timelines This patch sets the Network Overview and Waterfall caluclators to now have a default of 100ms minimum time rather than 1 second minimum time. R=dgozman,paulirish BUG=663578 Committed: https://crrev.com/aedaf6c71c0c9d3626937ea4ae5ed89fe08d3b42 Cr-Commit-Position: refs/heads/master@{#431008}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M third_party/WebKit/Source/devtools/front_end/network/NetworkTimeCalculator.js View 2 chunks +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui_lazy/TimelineOverviewPane.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
allada
PTL
4 years, 1 month ago (2016-11-09 00:40:02 UTC) #1
paulirish
lgtm on the UX changing the minimum duration of overviewpane and waterfall to be 100ms.
4 years, 1 month ago (2016-11-09 00:48:22 UTC) #2
dgozman
lgtm
4 years, 1 month ago (2016-11-09 00:57:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2490473006/1
4 years, 1 month ago (2016-11-09 18:11:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-09 19:30:40 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 19:44:49 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aedaf6c71c0c9d3626937ea4ae5ed89fe08d3b42
Cr-Commit-Position: refs/heads/master@{#431008}

Powered by Google App Engine
This is Rietveld 408576698