third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvasModules.cpp - Issue 2490443002: Make OffscreenCanvas an EventTarget

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvasModules.cpp

Issue 2490443002: Make OffscreenCanvas an EventTarget (Closed)

Patch Set: keep a Member<ExecutionContext> in OffscreenCanvas Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.h ('K') | « third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.idl ('k') | third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvasModules.cpp

diff --git a/third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvasModules.cpp b/third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvasModules.cpp

index ea89f7b72db128a7c59a2b1d13142b45dcf12515..39fe0288cf4e6996f26cecf22cffc5a67839283a 100644

--- a/third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvasModules.cpp

+++ b/third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvasModules.cpp

@@ -23,6 +23,7 @@ void OffscreenCanvasModules::getContext(

return;

}

+ offscreenCanvas.setExecutionContext(scriptState->getExecutionContext());

Justin Novosad 2016/11/14 19:45:08 Add a comment: OffscreenCanvas cannot be transferr

CanvasRenderingContext* context =

offscreenCanvas.getCanvasRenderingContext(scriptState, id, attributes);

if (context)