Issue 249044: Rebaseline a couple of tests whose expectations are slightly different than W...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 249044: Rebaseline a couple of tests whose expectations are slightly different than W... (Closed)

Created:
11 years, 2 months ago by Nate Chapin

Modified:
9 years, 5 months ago

Reviewers:
dglazkov

CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Rebaseline a couple of tests whose expectations are slightly different than WebKit's due to slight font differences. BUG=10433 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27668

Patch Set 1 #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+292 lines, -2 lines)			Patch
A	webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/block/float/nested-clearance-expected.checksum	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/block/float/nested-clearance-expected.png	View	Binary file		0 comments	Download
A	webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/block/float/nested-clearance-expected.checksum	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/block/float/nested-clearance-expected.png	View	Binary file		0 comments	Download
A	webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/block/float/nested-clearance-expected.txt	View	1 chunk	+92 lines, -0 lines	0 comments	Download
A	webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/dom/Window/webkitConvertPoint-expected.txt	View	1 chunk	+198 lines, -0 lines	0 comments	Download
M	webkit/tools/layout_tests/test_expectations.txt	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nate Chapin

Is it ok that the expectations for webkitConvertPoint will have a bunch of lines that ...

11 years, 2 months ago (2009-09-30 22:01:23 UTC) #1

dglazkov

11 years, 2 months ago (2009-09-30 22:18:46 UTC) #2

LGTM.

This test looks like it was written for specific text metrics, which probably
makes it a faulty test. I don't mind the rebaseline, but ideally we should fix
the test to be metrics-agnostic.

Expand Messages | Collapse Messages