Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2490433002: DevTools: clicking console messages with traces should check for links (Closed)

Created:
4 years, 1 month ago by luoe
Modified:
4 years, 1 month ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: clicking console messages with traces should check for links Console messages with a trace can be clicked to toggle their expanded state. The click handler was intercepting and consuming clicks on links that were part of the message's text. As a result, some anchors stopped revealing in the sources panel and navigated the target page instead. This CL makes the handler check whether the click target was an anchor first to allow the document's handler to follow relative links. BUG=660521 Committed: https://crrev.com/67fdae4bf2f450c494f76623c6810e18443067e2 Cr-Commit-Position: refs/heads/master@{#430796}

Patch Set 1 #

Messages

Total messages: 15 (10 generated)
luoe
PTAL
4 years, 1 month ago (2016-11-08 03:03:20 UTC) #4
dgozman
lgtm
4 years, 1 month ago (2016-11-08 19:52:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2490433002/1
4 years, 1 month ago (2016-11-09 00:30:09 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-09 00:39:01 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 00:44:52 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/67fdae4bf2f450c494f76623c6810e18443067e2
Cr-Commit-Position: refs/heads/master@{#430796}

Powered by Google App Engine
This is Rietveld 408576698