Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 249043: New expectations so that we can enable pixel tests. This CL does not include ... (Closed)

Created:
11 years, 2 months ago by Avi (use Gerrit)
Modified:
9 years, 7 months ago
Reviewers:
Dirk Pranke, dglazkov
CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org, ojan, Mark Mentovai, tony, Pam (message me for reviews), Amanda Walker
Visibility:
Public.

Description

New expectations so that we can enable pixel tests. This CL does not include the change to the buildbot script to turn on pixel tests on the Mac (in tools/buildbot/scripts/master/factory/chromium_commands.py); will coordinate with the buildbot masters. BUG=http://crbug.com/20445 TEST=no pixel test unexpected failures Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27838

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+749 lines, -14 lines) Patch
A webkit/data/layout_tests/platform/chromium-mac/LayoutTests/fast/forms/menulist-style-color-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-mac/LayoutTests/fast/forms/menulist-style-color-expected.png View Binary file 0 comments Download
M webkit/tools/layout_tests/test_expectations.txt View 1 2 3 4 5 6 7 6 chunks +748 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Avi (use Gerrit)
Dmitri: review All y'all: FYI I have not yet run this past the layout test ...
11 years, 2 months ago (2009-09-30 21:56:26 UTC) #1
dglazkov
Awesome. Horrifying. New headaches. LGTM.
11 years, 2 months ago (2009-09-30 22:24:30 UTC) #2
Dirk Pranke
http://codereview.chromium.org/249043/diff/1001/2001 File webkit/tools/layout_tests/test_expectations.txt (right): http://codereview.chromium.org/249043/diff/1001/2001#newcode1481 Line 1481: BUG23498 MAC : LayoutTests/css1/color_and_background/background_position.html = IMAGE I don't ...
11 years, 2 months ago (2009-09-30 22:31:32 UTC) #3
Avi (use Gerrit)
11 years, 2 months ago (2009-10-01 03:00:53 UTC) #4
http://codereview.chromium.org/249043/diff/1001/2001
File webkit/tools/layout_tests/test_expectations.txt (right):

http://codereview.chromium.org/249043/diff/1001/2001#newcode1481
Line 1481: BUG23498 MAC :
LayoutTests/css1/color_and_background/background_position.html = IMAGE
On 2009/09/30 22:31:33, dpranke wrote:
> I don't suppose any of these can be globbed together into directory-level
> expectations, can they?

Nope. Basically, anything with a top-level scrollbar needs rebaselining and
that's a random attribute of the tests.

Powered by Google App Engine
This is Rietveld 408576698