Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Issue 2490403002: Mojo Bindings: Reset EDK error callback in ReportBadMessageTest::TearDown (Closed)

Created:
4 years, 1 month ago by Ken Rockot(use gerrit already)
Modified:
4 years, 1 month ago
Reviewers:
yzshen1
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo Bindings: Reset EDK error callback in ReportBadMessageTest::TearDown We were leaving a stale callback bound here which can cause other tests (namely things which explicitly test invalid message behavior) to UAF on the bound state. BUG=664236 R=yzshen@chromium.org Committed: https://crrev.com/9d4a788a20e336d82ba48f9918d0d09ebd17a787 Cr-Commit-Position: refs/heads/master@{#431413}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M mojo/public/cpp/bindings/tests/report_bad_message_unittest.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Ken Rockot(use gerrit already)
Your guess was pretty close :)
4 years, 1 month ago (2016-11-11 00:10:54 UTC) #3
yzshen1
lgtm Yay!
4 years, 1 month ago (2016-11-11 00:14:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2490403002/1
4 years, 1 month ago (2016-11-11 00:16:22 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-11 00:35:18 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 00:39:10 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9d4a788a20e336d82ba48f9918d0d09ebd17a787
Cr-Commit-Position: refs/heads/master@{#431413}

Powered by Google App Engine
This is Rietveld 408576698