Match camelCased SVG attributes selectors in html documents.

Match camelCased SVG attributes selectors in html documents.

Attribute names are stored lower-case in stylesheets in HTML documents.
SVG attribute names are normalized to the camelCase form in HTML
documents. That meant SVG attributes with camelCase like viewBox never
matched in HTML documents.

We had the same issue for camelCased element names in [1]. In that CL
we decided to allow insensitive matching for non-html elements in order
to avoid having to store the tag names twice in CSSSelector, even if
that is wrong according to the HTML spec. This CL does exactly the same
for attribute selectors.

[1] https://crrev.com/bab4aa7b9

R=sashab@chromium.org,esprehn@chromium.org
BUG=663798
Committed: https://crrev.com/b946c5d62ca51dff877a5a1947c62e78756bb38e
Cr-Commit-Position: refs/heads/master@{#431544}

[rune, 2016-11-11 00:11:25]

ptal

Added esprehn@ as you suggested/approved the mentioned spec violation for type
selectors.

[rune, 2016-11-11 00:11:49]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 00:12:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sashab, 2016-11-11 00:16:52]

Great comment in SelectorChecker.cpp :)

https://codereview.chromium.org/2490393002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/svg/css/attribute-selector-expected.txt
(right):

https://codereview.chromium.org/2490393002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/svg/css/attribute-selector-expected.txt:2: PASS
You shouldn't need this file if using testharness.js? Context:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/rDKsRjVYsZM

https://codereview.chromium.org/2490393002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/Attribute.h (right):

https://codereview.chromium.org/2490393002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/Attribute.h:85: if
(qualifiedName.localNameUpper() != m_name.localNameUpper())
You could move this into the return statement :)

[commit-bot: I haz the power, 2016-11-11 02:45:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 02:45:19]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rune, 2016-11-11 09:49:23]

https://codereview.chromium.org/2490393002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/svg/css/attribute-selector-expected.txt
(right):

https://codereview.chromium.org/2490393002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/svg/css/attribute-selector-expected.txt:2: PASS
On 2016/11/11 00:16:52, sashab wrote:
> You shouldn't need this file if using testharness.js? Context:
> https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/rDKsRjVYsZM

I've tried, but testharnessreport.js adds results to body:

  document.body.appendChild(results);

So, it's not working out-of-the-box for svg documents.

https://codereview.chromium.org/2490393002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/Attribute.h (right):

https://codereview.chromium.org/2490393002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/Attribute.h:85: if
(qualifiedName.localNameUpper() != m_name.localNameUpper())
On 2016/11/11 00:16:52, sashab wrote:
> You could move this into the return statement :)

Done.

[rune, 2016-11-11 09:50:01]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 09:50:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sashab, 2016-11-11 10:15:20]

lgtm

https://codereview.chromium.org/2490393002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/svg/css/attribute-selector-expected.txt
(right):

https://codereview.chromium.org/2490393002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/svg/css/attribute-selector-expected.txt:2: PASS
On 2016/11/11 at 09:49:23, rune wrote:
> On 2016/11/11 00:16:52, sashab wrote:
> > You shouldn't need this file if using testharness.js? Context:
> > https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/rDKsRjVYsZM
> 
> I've tried, but testharnessreport.js adds results to body:
> 
>   document.body.appendChild(results);
> 
> So, it's not working out-of-the-box for svg documents.

Hm :( That's no good. Maybe file a bug against that, and assign it to Mike West
(mkwst).

[commit-bot: I haz the power, 2016-11-11 11:14:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 11:14:29]

Dry run: This issue passed the CQ dry run.

[rune, 2016-11-11 11:50:52]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2016-11-11 11:51:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 11:55:27]

Committed patchset #2 (id:20001)

[rune, 2016-11-11 11:56:59]

On 2016/11/11 10:15:20, sashab wrote:

> Hm :( That's no good. Maybe file a bug against that, and assign it to Mike
West
> (mkwst).

crbug.com/664473

[commit-bot: I haz the power, 2016-11-11 12:00:26]

Description was changed from

==========
Match camelCased SVG attributes selectors in html documents.

Attribute names are stored lower-case in stylesheets in HTML documents.
SVG attribute names are normalized to the camelCase form in HTML
documents. That meant SVG attributes with camelCase like viewBox never
matched in HTML documents.

We had the same issue for camelCased element names in [1]. In that CL
we decided to allow insensitive matching for non-html elements in order
to avoid having to store the tag names twice in CSSSelector, even if
that is wrong according to the HTML spec. This CL does exactly the same
for attribute selectors.

[1] https://crrev.com/bab4aa7b9

R=sashab@chromium.org,esprehn@chromium.org
BUG=663798
==========

to

==========
Match camelCased SVG attributes selectors in html documents.

Attribute names are stored lower-case in stylesheets in HTML documents.
SVG attribute names are normalized to the camelCase form in HTML
documents. That meant SVG attributes with camelCase like viewBox never
matched in HTML documents.

We had the same issue for camelCased element names in [1]. In that CL
we decided to allow insensitive matching for non-html elements in order
to avoid having to store the tag names twice in CSSSelector, even if
that is wrong according to the HTML spec. This CL does exactly the same
for attribute selectors.

[1] https://crrev.com/bab4aa7b9

R=sashab@chromium.org,esprehn@chromium.org
BUG=663798

Committed: https://crrev.com/b946c5d62ca51dff877a5a1947c62e78756bb38e
Cr-Commit-Position: refs/heads/master@{#431544}
==========

[commit-bot: I haz the power, 2016-11-11 12:00:27]

Patchset 2 (id:??) landed as
https://crrev.com/b946c5d62ca51dff877a5a1947c62e78756bb38e
Cr-Commit-Position: refs/heads/master@{#431544}