Issue 2490363002: Clean up encoding of size and single entry flag in Instructions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2490363002: Clean up encoding of size and single entry flag in Instructions. (Closed)

Created:
4 years, 1 month ago by regis

Modified:
4 years, 1 month ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+55 lines, -27 lines)			Patch
M	runtime/vm/object.h	View	4 chunks	+39 lines, -13 lines	0 comments	Download
M	runtime/vm/object.cc	View	3 chunks	+7 lines, -6 lines	0 comments	Download
M	runtime/vm/precompiler.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/raw_object.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	runtime/vm/raw_object.cc	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	runtime/vm/snapshot.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 5 (2 generated)

regis

Slava, This is cleaning up the hacky encoding of instructions size and flag per your ...

4 years, 1 month ago (2016-11-10 22:39:38 UTC) #2

regis

4 years, 1 month ago (2016-11-11 19:09:42 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3bf67964400ed7a769284d233552f64278092866 (presubmit successful).