Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Unified Diff: ash/display/display_configuration_controller.cc

Issue 2490323003: Improve monitor compatibility error, move feedback link into button (Closed)
Patch Set: Tweaking display icon and feeback text, Merge Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/display/display_configuration_controller.cc
diff --git a/ash/display/display_configuration_controller.cc b/ash/display/display_configuration_controller.cc
index 1e7bc4c7803e15378aec7c69ec803e9da4519503..22f9dd1ed2a9f4edf87d07d96c6cd49ce0739d32 100644
--- a/ash/display/display_configuration_controller.cc
+++ b/ash/display/display_configuration_controller.cc
@@ -15,6 +15,7 @@
#include "ash/display/display_animator_chromeos.h"
#include "base/sys_info.h"
#include "grit/ash_strings.h"
+#include "ui/base/l10n/l10n_util.h"
#endif
namespace {
@@ -84,8 +85,11 @@ void DisplayConfigurationController::SetMirrorMode(bool mirror,
bool user_action) {
if (display_manager_->num_connected_displays() > 2) {
#if defined(OS_CHROMEOS)
- if (user_action)
- ShowDisplayErrorNotification(IDS_ASH_DISPLAY_MIRRORING_NOT_SUPPORTED);
+ if (user_action) {
+ base::string16 message =
+ l10n_util::GetStringUTF16(IDS_ASH_DISPLAY_MIRRORING_NOT_SUPPORTED);
Evan Stade 2016/12/12 23:44:17 nit: I'd prefer to inline this instead of creating
Greg Levin 2016/12/13 01:48:59 Done.
+ ShowDisplayErrorNotification(message, false);
+ }
#endif
return;
}

Powered by Google App Engine
This is Rietveld 408576698