ash/resources/vector_icons/display_notification.1x.icon - Issue 2490323003: Improve monitor compatibility error, move feedback link into button

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ash/resources/vector_icons/display_notification.1x.icon

Issue 2490323003: Improve monitor compatibility error, move feedback link into button (Closed)

Patch Set: Fix non-ChromeOS compile and move greys out of icon files Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 CANVAS_DIMENSIONS, 43,
	Evan Stade 2016/12/01 22:03:51 the dimensions of the 1x version need to be exactl the dimensions of the 1x version need to be exactly half the dimensions of the !1x (i.e. 2x) version. The dimensions of the 1x version are used as the DIP size for all scale factors, so basically we'll be drawing the 2x dsf version at 86px instead of 87, which would make all the dimensions slightly off. That said, you really shouldn't need a separate 1x version for icons of this size. That's really only meant to be used for small icons (on the order of 16 or 20dip) where pixel perfection is important. For icons of this size, one version should be fine. Greg Levin 2016/12/02 17:23:08 Ok, got it. I tried a few variations, and this is Show quoted text On 2016/12/01 22:03:51, Evan Stade wrote: > the dimensions of the 1x version need to be exactly half the dimensions of the > !1x (i.e. 2x) version. The dimensions of the 1x version are used as the DIP size > for all scale factors, so basically we'll be drawing the 2x dsf version at 86px > instead of 87, which would make all the dimensions slightly off. > > That said, you really shouldn't need a separate 1x version for icons of this > size. That's really only meant to be used for small icons (on the order of 16 or > 20dip) where pixel perfection is important. For icons of this size, one version > should be fine. Ok, got it. I tried a few variations, and this is what worked: I got rid of the 87px version, and renamed the 43px one from "display_notification.1x.icon" to "display_notification.icon". Everything looks fine this way. Let me know if this change is what you had in mind.
	6 PATH_COLOR_ARGB, 0xFF, 0xFF, 0xB0, 0x00,

	7 MOVE_TO, 35, 24,

	8 R_CUBIC_TO, -4.42f, 0, -8, 3.58f, -8, 8,

	9 R_CUBIC_TO, 0, 4.42f, 3.58f, 8, 8, 8,

	10 R_CUBIC_TO, 4.42f, 0, 8, -3.58f, 8, -8,

	11 R_CUBIC_TO, 0, -4.42f, -3.58f, -8, -8, -8,

	12 CLOSE,

	13 R_MOVE_TO, -1, 12,

	14 R_H_LINE_TO, 2,

	15 R_V_LINE_TO, -2,

	16 R_H_LINE_TO, -2,

	17 R_V_LINE_TO, 2,

	18 CLOSE,

	19 R_MOVE_TO, 0, -3,

	20 R_H_LINE_TO, 2,

	21 R_V_LINE_TO, -5,

	22 R_H_LINE_TO, -2,

	23 R_V_LINE_TO, 5,

	24 CLOSE,

	25 NEW_PATH,

	26 MOVE_TO, 3, 23,

	27 V_LINE_TO, 3,

	28 H_LINE_TO, 33,

	29 R_V_LINE_TO, 19.1f,

	30 R_CUBIC_TO, 0, 0, 1.97f, -0.4f, 3, -0.4f,

	31 R_V_LINE_TO, -18,

	32 CUBIC_TO, 36, 1.94f, 34.53f, 0.5f, 32.73f, 0,

	33 H_LINE_TO, 3.27f,

	34 CUBIC_TO, 1.47f, 0.5f, 0, 1.94f, 0, 3.7f,

	35 R_V_LINE_TO, 19.1f,

	36 R_CUBIC_TO, 0, 1.76f, 1.47f, 3.2f, 3.27f, 3.2f,

	37 H_LINE_TO, 15,

	38 R_LINE_TO, 0, 3.98f,

	39 R_LINE_TO, -2.95f, -0.02f,

	40 LINE_TO, 12, 33,

	41 R_H_LINE_TO, 12,

	42 R_LINE_TO, -0.05f, -3.03f,

	43 R_LINE_TO, -2.96f, 0.01f,

	44 LINE_TO, 21, 26,

	45 R_H_LINE_TO, 6.12f,

	46 R_CUBIC_TO, 0.96f, -1.17f, 3.62f, -2.99f, 3.62f, -2.99f,

	47 LINE_TO, 3, 23,

	48 CLOSE,

	49 END

OLD	NEW

« no previous file with comments | « ash/resources/vector_icons/display_notification.icon ('k') | ash/resources/vector_icons/notification_feedback.icon » ('j') | no next file with comments »