[Mac] Anchor profile switcher to left side of avatar button in RTL

chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm

Index: chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm
diff --git a/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm b/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm
index b2b55f8141b50264d1d86c4f210e36fc0326b1bd..b7c13322794258854920bec5d05e4c8b05271de7 100644
--- a/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm
+++ b/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm
@@ -43,6 +43,7 @@
 #import "chrome/browser/ui/cocoa/browser_window_utils.h"
 #import "chrome/browser/ui/cocoa/info_bubble_view.h"
 #import "chrome/browser/ui/cocoa/info_bubble_window.h"
+#include "chrome/browser/ui/cocoa/l10n_util.h"
 #include "chrome/browser/ui/cocoa/profiles/signin_view_controller_delegate_mac.h"
 #import "chrome/browser/ui/cocoa/profiles/user_manager_mac.h"
 #include "chrome/browser/ui/profile_chooser_constants.h"
@@ -1367,7 +1368,9 @@ class ActiveProfileObserverBridge : public AvatarMenuObserver,
         l10n_util::GetNSString(IDS_PROFILES_NEW_AVATAR_MENU_ACCESSIBLE_NAME)
                              forAttribute:NSAccessibilityHelpAttribute];
 
-    [[self bubble] setAlignment:info_bubble::kAlignRightEdgeToAnchorEdge];
+    [[self bubble] setAlignment:cocoa_l10n_util::ShouldDoExperimentalRTLLayout()
+                                    ? info_bubble::kAlignLeftEdgeToAnchorEdge

[Nico, 2016/11/15 16:32:51]

Hm, I wonder if the bubble's API should be "kAlignBegin/EndEdge" instead of
"Left/RightEdge" and then all the clients would pass what they want and the
bubble could have a single of these conditionals internally, instead of us
adding a conditional at each use (and then having a bug each time we forget).

[lgrey, 2016/11/15 17:41:37]

Done. This makes the zoom bubble look worse under the experimental RTL flags,
but that's the least of Omnibox's problem under the flag and will be fine once I
get there.

+                                    : info_bubble::kAlignRightEdgeToAnchorEdge];
     [[self bubble] setArrowLocation:info_bubble::kNoArrow];
     [[self bubble] setBackgroundColor:GetDialogBackgroundColor()];
     [self initMenuContentsWithView:viewMode_];