Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issue 2490303003: Add once field to devtools so it can be queried by lighthouse. (Closed)

Created:
4 years, 1 month ago by dtapuska
Modified:
4 years, 1 month ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, blink-reviews-bindings_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add once field to devtools so it can be queried by lighthouse. Allow the once field property on EventListener to be queried from the command line and devtools protocol. BUG=664213 Committed: https://crrev.com/311048bddd4ce2d5936b1d813b95a9a59c2ed674 Cr-Commit-Position: refs/heads/master@{#431630}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -14 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/elements/event-listeners-framework-with-service-worker-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/command-line-api-getEventListeners.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/command-line-api-getEventListeners-expected.txt View 10 chunks +21 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/event-listener-sidebar.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/event-listener-sidebar-custom-framework.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/event-listener-sidebar-custom-framework-expected.txt View 5 chunks +5 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/event-listener-sidebar-expected.txt View 5 chunks +12 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/event-listener-sidebar-jquery1-expected.txt View 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/event-listener-sidebar-jquery2-expected.txt View 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/event-listeners-about-blank.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/event-listeners-about-blank-expected.txt View 3 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8EventListenerInfo.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/browser_protocol.json View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/EventListenersUtils.js View 9 chunks +15 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/EventListenersView.js View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js View 4 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
dtapuska
4 years, 1 month ago (2016-11-11 15:58:17 UTC) #2
pfeldman
lgtm
4 years, 1 month ago (2016-11-11 20:11:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2490303003/1
4 years, 1 month ago (2016-11-11 20:21:41 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-11 20:43:15 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 21:00:29 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/311048bddd4ce2d5936b1d813b95a9a59c2ed674
Cr-Commit-Position: refs/heads/master@{#431630}

Powered by Google App Engine
This is Rietveld 408576698