Issue 249030: Disable "OK" button in edit dialog of bookmark button when name is not valid...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 249030: Disable "OK" button in edit dialog of bookmark button when name is not valid... (Closed)

Created:
11 years, 2 months ago by John Grabowski

Modified:
9 years, 6 months ago

Reviewers:
TVL

CC:
chromium-reviews_googlegroups.com, John Grabowski, ben+cc_chromium.org, pam+watch_chromium.org, tim (not reviewing), Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Disable "OK" button in edit dialog of bookmark button when name is not valid TEST=see bug BUG=http://crbug.com/19558 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27501

Patch Set 3 : '' #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -3 lines)			Patch
	M	chrome/browser/cocoa/bookmark_editor_controller.mm	View	1 2	4 chunks	+15 lines, -2 lines	0 comments	Download
	M	chrome/browser/cocoa/bookmark_editor_controller_unittest.mm	View		1 chunk	+12 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

TVL

lgtm http://codereview.chromium.org/249030/diff/1/3 File chrome/browser/cocoa/bookmark_editor_controller.mm (right): http://codereview.chromium.org/249030/diff/1/3#newcode147 Line 147: name_valid = false; { } on the ...

11 years, 2 months ago (2009-09-29 02:33:56 UTC) #2

John Grabowski

11 years, 2 months ago (2009-09-29 17:13:06 UTC) #3

http://codereview.chromium.org/249030/diff/1/3
File chrome/browser/cocoa/bookmark_editor_controller.mm (right):

http://codereview.chromium.org/249030/diff/1/3#newcode147
Line 147: name_valid = false;
On 2009/09/29 02:33:56, TVL wrote:
> { } on the then clause for safety since the condition is long you almost lose
> the then?

Done.

Expand Messages | Collapse Messages

Issue 249030: Disable "OK" button in edit dialog of bookmark button when name is not valid... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages