Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 249030: Disable "OK" button in edit dialog of bookmark button when name is not valid... (Closed)

Created:
11 years, 2 months ago by John Grabowski
Modified:
9 years, 6 months ago
Reviewers:
TVL
CC:
chromium-reviews_googlegroups.com, John Grabowski, ben+cc_chromium.org, pam+watch_chromium.org, tim (not reviewing), Paweł Hajdan Jr.
Visibility:
Public.

Description

Disable "OK" button in edit dialog of bookmark button when name is not valid TEST=see bug BUG=http://crbug.com/19558 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27501

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -3 lines) Patch
M chrome/browser/cocoa/bookmark_editor_controller.mm View 1 2 4 chunks +15 lines, -2 lines 0 comments Download
M chrome/browser/cocoa/bookmark_editor_controller_unittest.mm View 1 chunk +12 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
John Grabowski
11 years, 2 months ago (2009-09-29 00:48:18 UTC) #1
TVL
lgtm http://codereview.chromium.org/249030/diff/1/3 File chrome/browser/cocoa/bookmark_editor_controller.mm (right): http://codereview.chromium.org/249030/diff/1/3#newcode147 Line 147: name_valid = false; { } on the ...
11 years, 2 months ago (2009-09-29 02:33:56 UTC) #2
John Grabowski
11 years, 2 months ago (2009-09-29 17:13:06 UTC) #3
http://codereview.chromium.org/249030/diff/1/3
File chrome/browser/cocoa/bookmark_editor_controller.mm (right):

http://codereview.chromium.org/249030/diff/1/3#newcode147
Line 147: name_valid = false;
On 2009/09/29 02:33:56, TVL wrote:
> { } on the then clause for safety since the condition is long you almost lose
> the then?

Done.

Powered by Google App Engine
This is Rietveld 408576698