Use parseHTMLInteger in HTMLLIElement

Use parseHTMLInteger in HTMLLIElement

Use parseHTMLInteger in HTMLLIElement instead of
toInt to avoid problems when handling -2147483648.

BUG=657448
Committed: https://crrev.com/be05dcac5f912363b08b387fa798069656eec8aa
Cr-Commit-Position: refs/heads/master@{#432106}

[rwlbuis, 2016-11-10 20:56:30]

Description was changed from

==========
657448 WIP

BUG=
==========

to

==========
657448 WIP

BUG=657448
==========

[rwlbuis, 2016-11-10 20:59:12]

Description was changed from

==========
657448 WIP

BUG=657448
==========

to

==========
Use parseHTMLInteger in HTMLLIElement

Use parseHTMLInteger in HTMLLIElement instead of toInt to avoid
problems when handling -2147483648.

BUG=657448
==========

[rwlbuis, 2016-11-10 20:59:24]

Description was changed from

==========
Use parseHTMLInteger in HTMLLIElement

Use parseHTMLInteger in HTMLLIElement instead of toInt to avoid
problems when handling -2147483648.

BUG=657448
==========

to

==========
Use parseHTMLInteger in HTMLLIElement

Use parseHTMLInteger in HTMLLIElement instead of
toInt to avoid problems when handling -2147483648.

BUG=657448
==========

[rwlbuis, 2016-11-11 03:37:32]

rob.buis@samsung.com changed reviewers:
+ tkent@chromium.org

[rwlbuis, 2016-11-11 03:37:33]

PTAL.

[tkent, 2016-11-11 03:43:47]

Needs a test.

[rwlbuis, 2016-11-11 13:31:42]

On 2016/11/11 03:43:47, tkent wrote:
> Needs a test.

Done.

[tkent, 2016-11-14 02:33:57]

https://codereview.chromium.org/2490283002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/dom/tabindex-overflow.html (right):

https://codereview.chromium.org/2490283002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/dom/tabindex-overflow.html:1: <li
value="-2147483648">
As for the file name, 'tabindex' doesn't look suitable.

Probably the test should be in LayoutTests/fast/lists/.

[rwlbuis, 2016-11-14 13:47:34]

https://codereview.chromium.org/2490283002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/dom/tabindex-overflow.html (right):

https://codereview.chromium.org/2490283002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/dom/tabindex-overflow.html:1: <li
value="-2147483648">
On 2016/11/14 02:33:57, tkent wrote:
> As for the file name, 'tabindex' doesn't look suitable.
> 
> Probably the test should be in LayoutTests/fast/lists/.

Ouch, I was probably doing too many things at the same time :)

Rename and moved the test in the latest patch.

[tkent, 2016-11-14 23:07:16]

lgtm

[rwlbuis, 2016-11-15 00:12:59]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2016-11-15 00:14:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 02:18:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 02:18:27]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rwlbuis, 2016-11-15 02:21:32]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2016-11-15 02:22:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 05:05:54]

Description was changed from

==========
Use parseHTMLInteger in HTMLLIElement

Use parseHTMLInteger in HTMLLIElement instead of
toInt to avoid problems when handling -2147483648.

BUG=657448
==========

to

==========
Use parseHTMLInteger in HTMLLIElement

Use parseHTMLInteger in HTMLLIElement instead of
toInt to avoid problems when handling -2147483648.

BUG=657448
==========

[commit-bot: I haz the power, 2016-11-15 05:05:55]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-15 05:14:10]

Description was changed from

==========
Use parseHTMLInteger in HTMLLIElement

Use parseHTMLInteger in HTMLLIElement instead of
toInt to avoid problems when handling -2147483648.

BUG=657448
==========

to

==========
Use parseHTMLInteger in HTMLLIElement

Use parseHTMLInteger in HTMLLIElement instead of
toInt to avoid problems when handling -2147483648.

BUG=657448

Committed: https://crrev.com/be05dcac5f912363b08b387fa798069656eec8aa
Cr-Commit-Position: refs/heads/master@{#432106}
==========

[commit-bot: I haz the power, 2016-11-15 05:14:11]

Patchset 3 (id:??) landed as
https://crrev.com/be05dcac5f912363b08b387fa798069656eec8aa
Cr-Commit-Position: refs/heads/master@{#432106}