Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: cc/trees/effect_node.h

Issue 2490273004: Move cc::ClipNode::target_is_clipped to cc::EffectNode (Closed)
Patch Set: one more todo comment Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/trees/draw_property_utils.cc ('k') | cc/trees/effect_node.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/effect_node.h
diff --git a/cc/trees/effect_node.h b/cc/trees/effect_node.h
index e1699be82e38bcd1c6963f8b17f6e8dc8ff48cf7..36692ebe9aa2034a5eb3b464d27e9c35a98bb7b7 100644
--- a/cc/trees/effect_node.h
+++ b/cc/trees/effect_node.h
@@ -44,6 +44,13 @@ struct CC_EXPORT EffectNode {
bool has_render_surface;
RenderSurfaceImpl* render_surface;
+ // Only applicable if has render surface. A true value means a clip needs to
+ // be applied to the output of the surface when it is drawn onto its parent
+ // surface.
+ // TODO(crbug.com/504464): There is ongoing work to delay render surface
+ // decision to later phase of the pipeline. This flag shall be removed and
+ // computed during render surface decision.
+ bool surface_is_clipped;
bool has_copy_request;
bool hidden_by_backface_visibility;
bool double_sided;
« no previous file with comments | « cc/trees/draw_property_utils.cc ('k') | cc/trees/effect_node.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698