Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(872)

Unified Diff: cc/trees/clip_node.h

Issue 2490273004: Move cc::ClipNode::target_is_clipped to cc::EffectNode (Closed)
Patch Set: one more todo comment Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/trees/clip_node.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/clip_node.h
diff --git a/cc/trees/clip_node.h b/cc/trees/clip_node.h
index 5ce9f9b645ab4687ca6fd1f74d73cd7acdca3e50..a7c5b45bed6309b22cb806ea5b4951a4c8df9e4b 100644
--- a/cc/trees/clip_node.h
+++ b/cc/trees/clip_node.h
@@ -59,15 +59,15 @@ struct CC_EXPORT ClipNode {
int target_transform_id;
// The id of the effect node that defines the clip node's target space.
+ // TODO(crbug.com/642581 crbug.com/642584): As we progress toward SPv2 and
+ // layer list mode, there may be layers having the same clip but draw onto
+ // different target. Target information shall be removed from here.
int target_effect_id;
// When true, |clip_in_target_space| does not include clips from ancestor
// nodes.
bool layer_clipping_uses_only_local_clip : 1;
- // True if target surface needs to be drawn with a clip applied.
- bool target_is_clipped : 1;
-
// True if layers with this clip tree node need to be drawn with a clip
// applied.
bool layers_are_clipped : 1;
« no previous file with comments | « no previous file | cc/trees/clip_node.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698