Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Side by Side Diff: cc/trees/effect_node.h

Issue 2490273004: Move cc::ClipNode::target_is_clipped to cc::EffectNode (Closed)
Patch Set: one more todo comment Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/trees/draw_property_utils.cc ('k') | cc/trees/effect_node.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CC_TREES_EFFECT_NODE_H_ 5 #ifndef CC_TREES_EFFECT_NODE_H_
6 #define CC_TREES_EFFECT_NODE_H_ 6 #define CC_TREES_EFFECT_NODE_H_
7 7
8 #include "cc/base/cc_export.h" 8 #include "cc/base/cc_export.h"
9 #include "cc/output/filter_operations.h" 9 #include "cc/output/filter_operations.h"
10 #include "third_party/skia/include/core/SkXfermode.h" 10 #include "third_party/skia/include/core/SkXfermode.h"
(...skipping 26 matching lines...) Expand all
37 gfx::PointF filters_origin; 37 gfx::PointF filters_origin;
38 38
39 SkXfermode::Mode blend_mode; 39 SkXfermode::Mode blend_mode;
40 40
41 gfx::Vector2dF surface_contents_scale; 41 gfx::Vector2dF surface_contents_scale;
42 42
43 gfx::Size unscaled_mask_target_size; 43 gfx::Size unscaled_mask_target_size;
44 44
45 bool has_render_surface; 45 bool has_render_surface;
46 RenderSurfaceImpl* render_surface; 46 RenderSurfaceImpl* render_surface;
47 // Only applicable if has render surface. A true value means a clip needs to
48 // be applied to the output of the surface when it is drawn onto its parent
49 // surface.
50 // TODO(crbug.com/504464): There is ongoing work to delay render surface
51 // decision to later phase of the pipeline. This flag shall be removed and
52 // computed during render surface decision.
53 bool surface_is_clipped;
47 bool has_copy_request; 54 bool has_copy_request;
48 bool hidden_by_backface_visibility; 55 bool hidden_by_backface_visibility;
49 bool double_sided; 56 bool double_sided;
50 bool is_drawn; 57 bool is_drawn;
51 // TODO(jaydasika) : Delete this after implementation of 58 // TODO(jaydasika) : Delete this after implementation of
52 // SetHideLayerAndSubtree is cleaned up. (crbug.com/595843) 59 // SetHideLayerAndSubtree is cleaned up. (crbug.com/595843)
53 bool subtree_hidden; 60 bool subtree_hidden;
54 bool has_potential_filter_animation; 61 bool has_potential_filter_animation;
55 bool has_potential_opacity_animation; 62 bool has_potential_opacity_animation;
56 bool is_currently_animating_filter; 63 bool is_currently_animating_filter;
(...skipping 10 matching lines...) Expand all
67 int mask_layer_id; 74 int mask_layer_id;
68 75
69 bool operator==(const EffectNode& other) const; 76 bool operator==(const EffectNode& other) const;
70 77
71 void AsValueInto(base::trace_event::TracedValue* value) const; 78 void AsValueInto(base::trace_event::TracedValue* value) const;
72 }; 79 };
73 80
74 } // namespace cc 81 } // namespace cc
75 82
76 #endif // CC_TREES_EFFECT_NODE_H_ 83 #endif // CC_TREES_EFFECT_NODE_H_
OLDNEW
« no previous file with comments | « cc/trees/draw_property_utils.cc ('k') | cc/trees/effect_node.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698