Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Side by Side Diff: cc/trees/clip_node.h

Issue 2490273004: Move cc::ClipNode::target_is_clipped to cc::EffectNode (Closed)
Patch Set: one more todo comment Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | cc/trees/clip_node.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CC_TREES_CLIP_NODE_H_ 5 #ifndef CC_TREES_CLIP_NODE_H_
6 #define CC_TREES_CLIP_NODE_H_ 6 #define CC_TREES_CLIP_NODE_H_
7 7
8 #include "cc/base/cc_export.h" 8 #include "cc/base/cc_export.h"
9 #include "ui/gfx/geometry/rect_f.h" 9 #include "ui/gfx/geometry/rect_f.h"
10 10
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 gfx::RectF combined_clip_in_target_space; 52 gfx::RectF combined_clip_in_target_space;
53 gfx::RectF clip_in_target_space; 53 gfx::RectF clip_in_target_space;
54 54
55 // The id of the transform node that defines the clip node's local space. 55 // The id of the transform node that defines the clip node's local space.
56 int transform_id; 56 int transform_id;
57 57
58 // The id of the transform node that defines the clip node's target space. 58 // The id of the transform node that defines the clip node's target space.
59 int target_transform_id; 59 int target_transform_id;
60 60
61 // The id of the effect node that defines the clip node's target space. 61 // The id of the effect node that defines the clip node's target space.
62 // TODO(crbug.com/642581 crbug.com/642584): As we progress toward SPv2 and
63 // layer list mode, there may be layers having the same clip but draw onto
64 // different target. Target information shall be removed from here.
62 int target_effect_id; 65 int target_effect_id;
63 66
64 // When true, |clip_in_target_space| does not include clips from ancestor 67 // When true, |clip_in_target_space| does not include clips from ancestor
65 // nodes. 68 // nodes.
66 bool layer_clipping_uses_only_local_clip : 1; 69 bool layer_clipping_uses_only_local_clip : 1;
67 70
68 // True if target surface needs to be drawn with a clip applied.
69 bool target_is_clipped : 1;
70
71 // True if layers with this clip tree node need to be drawn with a clip 71 // True if layers with this clip tree node need to be drawn with a clip
72 // applied. 72 // applied.
73 bool layers_are_clipped : 1; 73 bool layers_are_clipped : 1;
74 bool layers_are_clipped_when_surfaces_disabled : 1; 74 bool layers_are_clipped_when_surfaces_disabled : 1;
75 75
76 // Nodes that correspond to unclipped surfaces disregard ancestor clips. 76 // Nodes that correspond to unclipped surfaces disregard ancestor clips.
77 bool resets_clip : 1; 77 bool resets_clip : 1;
78 78
79 bool operator==(const ClipNode& other) const; 79 bool operator==(const ClipNode& other) const;
80 80
81 void AsValueInto(base::trace_event::TracedValue* value) const; 81 void AsValueInto(base::trace_event::TracedValue* value) const;
82 }; 82 };
83 83
84 } // namespace cc 84 } // namespace cc
85 85
86 #endif // CC_TREES_CLIP_NODE_H_ 86 #endif // CC_TREES_CLIP_NODE_H_
OLDNEW
« no previous file with comments | « no previous file | cc/trees/clip_node.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698