Couple of fixes for DesktopWindowTreeHostMus.

Couple of fixes for DesktopWindowTreeHostMus.

. Init() needs to set the bounds if bounds was passed in the
  InitParams.
. ShowWindowWithState() needs to call to SetInitialFocus(), matches
  that of other DesktopWindowTreeHost impls.
. Implements CenterWindow() to do the right thing (logic matches that
  of other DesktopWindowTreeHosts).
. And HasCapture() for mus should always return true. This is because
  DesktopNativeWidgetAura has the real checks and only calls to
  DesktopWindowTreeHostMus if everything mus cares about is true. So,
  it can always return true.

BUG=660994
TEST=covered by tests
R=msw@chromium.org

Committed: https://crrev.com/f3e7874130cb59bc124f7fad55a81ac5967e57e7
Cr-Commit-Position: refs/heads/master@{#431355}

[sky, 2016-11-10 17:54:20]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 17:54:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2016-11-10 18:27:46]

lgtm with minor comment/questions

https://codereview.chromium.org/2490273002/diff/20001/ui/views/mus/desktop_wi...
File ui/views/mus/desktop_window_tree_host_mus.cc (right):

https://codereview.chromium.org/2490273002/diff/20001/ui/views/mus/desktop_wi...
ui/views/mus/desktop_window_tree_host_mus.cc:118:
native_widget_delegate_->AsWidget()->SetInitialFocus(state);
q: Should this check if native_widget_delgate_->CanActivate like
NativeWidgetMus? Also, do we care about the return value like NativeWidgetAura?
"Returns true if the initial focus has been set or the window should not set the
initial focus, or false if the caller should set the initial focus (if any)."

https://codereview.chromium.org/2490273002/diff/20001/ui/views/mus/desktop_wi...
ui/views/mus/desktop_window_tree_host_mus.cc:172: gfx::Rect resulting_bounds(
Use gfx::Rect::ClampToCenteredSize, then skip AdjustToFit?

[commit-bot: I haz the power, 2016-11-10 18:58:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 18:58:01]

Dry run: This issue passed the CQ dry run.

[sky, 2016-11-10 20:17:57]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[sky, 2016-11-10 20:18:11]

https://codereview.chromium.org/2490273002/diff/20001/ui/views/mus/desktop_wi...
File ui/views/mus/desktop_window_tree_host_mus.cc (right):

https://codereview.chromium.org/2490273002/diff/20001/ui/views/mus/desktop_wi...
ui/views/mus/desktop_window_tree_host_mus.cc:118:
native_widget_delegate_->AsWidget()->SetInitialFocus(state);
On 2016/11/10 18:27:45, msw wrote:
> q: Should this check if native_widget_delgate_->CanActivate like
> NativeWidgetMus? Also, do we care about the return value like
NativeWidgetAura?
> "Returns true if the initial focus has been set or the window should not set
the
> initial focus, or false if the caller should set the initial focus (if any)."

I'm not exactly sure. That doesn't exist in the desktopwindowtreehost impls,
which seems weird. But I added it here for consistency.

https://codereview.chromium.org/2490273002/diff/20001/ui/views/mus/desktop_wi...
ui/views/mus/desktop_window_tree_host_mus.cc:172: gfx::Rect resulting_bounds(
On 2016/11/10 18:27:45, msw wrote:
> Use gfx::Rect::ClampToCenteredSize, then skip AdjustToFit?

Good call! Done.

[sky, 2016-11-10 20:18:15]

The CQ bit was checked by sky@chromium.org

[sky, 2016-11-10 20:18:15]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2490273002/#ps40001
(title: "feedback")

[commit-bot: I haz the power, 2016-11-10 20:18:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 21:17:50]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-10 21:23:42]

Description was changed from

==========
Couple of fixes for DesktopWindowTreeHostMus.

. Init() needs to set the bounds if bounds was passed in the
  InitParams.
. ShowWindowWithState() needs to call to SetInitialFocus(), matches
  that of other DesktopWindowTreeHost impls.
. Implements CenterWindow() to do the right thing (logic matches that
  of other DesktopWindowTreeHosts).
. And HasCapture() for mus should always return true. This is because
  DesktopNativeWidgetAura has the real checks and only calls to
  DesktopWindowTreeHostMus if everything mus cares about is true. So,
  it can always return true.

BUG=660994
TEST=covered by tests
R=msw@chromium.org
==========

to

==========
Couple of fixes for DesktopWindowTreeHostMus.

. Init() needs to set the bounds if bounds was passed in the
  InitParams.
. ShowWindowWithState() needs to call to SetInitialFocus(), matches
  that of other DesktopWindowTreeHost impls.
. Implements CenterWindow() to do the right thing (logic matches that
  of other DesktopWindowTreeHosts).
. And HasCapture() for mus should always return true. This is because
  DesktopNativeWidgetAura has the real checks and only calls to
  DesktopWindowTreeHostMus if everything mus cares about is true. So,
  it can always return true.

BUG=660994
TEST=covered by tests
R=msw@chromium.org

Committed: https://crrev.com/f3e7874130cb59bc124f7fad55a81ac5967e57e7
Cr-Commit-Position: refs/heads/master@{#431355}
==========

[commit-bot: I haz the power, 2016-11-10 21:23:43]

Patchset 3 (id:??) landed as
https://crrev.com/f3e7874130cb59bc124f7fad55a81ac5967e57e7
Cr-Commit-Position: refs/heads/master@{#431355}