Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2490253002: [Mac/GN] Create symlinks for every item //chrome:chrome_framework when versioned. (Closed)

Created:
4 years, 1 month ago by Robert Sesek
Modified:
4 years, 1 month ago
Reviewers:
Nico
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac/GN] Create symlinks for every item //chrome:chrome_framework when versioned. BUG=662466 Committed: https://crrev.com/5669b7c1dd94fad2dfc33974a6c91e4a899dbade Cr-Commit-Position: refs/heads/master@{#431292}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M chrome/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Robert Sesek
4 years, 1 month ago (2016-11-10 17:19:34 UTC) #2
Nico
rs-lgtm
4 years, 1 month ago (2016-11-10 17:30:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2490253002/1
4 years, 1 month ago (2016-11-10 17:52:52 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-10 18:15:55 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 18:38:41 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5669b7c1dd94fad2dfc33974a6c91e4a899dbade
Cr-Commit-Position: refs/heads/master@{#431292}

Powered by Google App Engine
This is Rietveld 408576698