Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2490233004: - Turn on canonicalization verification after a reload in debug mode. (Closed)

Created:
4 years, 1 month ago by siva
Modified:
4 years, 1 month ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

- Turn on canonicalization verification after a reload in debug mode. - Rehash the canonical constants table for all new classes, this fixes numerous issues found with the canonical verification also fixes https://github.com/dart-lang/sdk/issues/26868 - Added issue https://github.com/dart-lang/sdk/issues/27803 and https://github.com/dart-lang/sdk/issues/27802 for remaining bugs. BUG=#26868 R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/84ad096687863ec8f3291006aa1bbbd699c9889c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -11 lines) Patch
M runtime/tests/vm/vm.status View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/isolate.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M runtime/vm/isolate_reload.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tests/lib/lib.status View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
siva
4 years, 1 month ago (2016-11-10 23:35:06 UTC) #2
rmacnak
LGTM
4 years, 1 month ago (2016-11-10 23:43:13 UTC) #3
siva
4 years, 1 month ago (2016-11-11 00:13:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
84ad096687863ec8f3291006aa1bbbd699c9889c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698