third_party/WebKit/Source/core/html/HTMLImageElement.idl - Issue 2490233002: Use unsigned longs in HTMLImageElement idl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLImageElement.idl

Issue 2490233002: Use unsigned longs in HTMLImageElement idl (Closed)

Patch Set: Fix compile error Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLImageElement.cpp ('k') | third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLImageElement.idl

diff --git a/third_party/WebKit/Source/core/html/HTMLImageElement.idl b/third_party/WebKit/Source/core/html/HTMLImageElement.idl

index ddad655d4157f1705009989575aa6274a4d1fb47..9b95061f5ec838f5b0305bc09dc41fd4cede2f25 100644

--- a/third_party/WebKit/Source/core/html/HTMLImageElement.idl

+++ b/third_party/WebKit/Source/core/html/HTMLImageElement.idl

@@ -20,11 +20,10 @@

// https://html.spec.whatwg.org/#the-img-element

-// TODO(foolip): All long types in this interfaces should be unsigned long.

[

ActiveScriptWrappable,

ConstructorCallWith=Document,

- NamedConstructor=Image(optional long width, optional long height),

+ NamedConstructor=Image(optional unsigned long width, optional unsigned long height),

] interface HTMLImageElement : HTMLElement {

[CEReactions, Reflect] attribute DOMString alt;

[CEReactions, Reflect, URL] attribute DOMString src;

@@ -33,10 +32,10 @@

[CEReactions, Reflect, ReflectOnly=("anonymous","use-credentials"), ReflectEmpty="anonymous", ReflectInvalid="anonymous"] attribute DOMString? crossOrigin;

[CEReactions, Reflect] attribute DOMString useMap;

[CEReactions, Reflect] attribute boolean isMap;

- [CEReactions] attribute long width;

- [CEReactions] attribute long height;

- readonly attribute long naturalWidth;

- readonly attribute long naturalHeight;

+ [CEReactions] attribute unsigned long width;

+ [CEReactions] attribute unsigned long height;

+ readonly attribute unsigned long naturalWidth;

+ readonly attribute unsigned long naturalHeight;

readonly attribute boolean complete;

readonly attribute DOMString currentSrc;

[CEReactions, Reflect, ReflectOnly=("","no-referrer","origin","no-referrer-when-downgrade","origin-when-cross-origin","unsafe-url"), ReflectMissing="", ReflectInvalid=""] attribute DOMString referrerPolicy;