Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 2490213002: Revert of Disable flaky tests in ChildTracingTest on Android. (Closed)

Created:
4 years, 1 month ago by perezju
Modified:
4 years, 1 month ago
Reviewers:
Guido Urdaneta
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable flaky tests in ChildTracingTest on Android. (patchset #1 id:1 of https://codereview.chromium.org/2432443003/ ) Reason for revert: Fix in place for issue that introduced flakiness of these tests. Original issue's description: > Disable flaky tests in ChildTracingTest on Android. > > BUG=656729 > TBR=jbauman@chromium.org > > Committed: https://crrev.com/356f59fca3ff5b0e1d82d0a85087c9628154682a > Cr-Commit-Position: refs/heads/master@{#425988} TBR=guidou@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=656729 Committed: https://crrev.com/170d17d3be602605691146d3f2e3675d52334bbc Cr-Commit-Position: refs/heads/master@{#431246}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -26 lines) Patch
M components/tracing/child/child_trace_message_filter_browsertest.cc View 3 chunks +3 lines, -26 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
perezju
Created Revert of Disable flaky tests in ChildTracingTest on Android.
4 years, 1 month ago (2016-11-10 13:49:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2490213002/1
4 years, 1 month ago (2016-11-10 13:49:22 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-10 14:09:47 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 14:13:30 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/170d17d3be602605691146d3f2e3675d52334bbc
Cr-Commit-Position: refs/heads/master@{#431246}

Powered by Google App Engine
This is Rietveld 408576698