third_party/WebKit/Source/platform/exported/WebRTCStats.cpp - Issue 2490183002: Filter webrtc::RTCStats by whitelist in surfacing them to Blink.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/platform/exported/WebRTCStats.cpp

Issue 2490183002: Filter webrtc::RTCStats by whitelist in surfacing them to Blink. (Closed)

Patch Set: Make win compile: BLINK_PLATFORM_EXPORT and cpp file (also rebase /w master) Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "public/platform/WebRTCStats.h"

	6

	7 namespace blink {

	8

	9 WebRTCStatsReport::~WebRTCStatsReport() {
	foolip 2016/11/24 12:26:30 Do you have other examples of where the destructor Do you have other examples of where the destructor had to be outlined to fix the windows build? Can you document here why it's done like this? hbos_chromium 2016/11/24 12:55:42 No, I don't understand this. Most examples have a Show quoted text On 2016/11/24 12:26:30, foolip wrote: > Do you have other examples of where the destructor had to be outlined to fix the > windows build? Can you document here why it's done like this? No, I don't understand this. Most examples have a .cpp file and a .h file, but there are cases of inlined virual destructors that are BLINK_PLATFORM_EXPORT'ed.
	10 }

	11

	12 WebRTCStats::~WebRTCStats() {

	13 }

	14

	15 WebRTCStatsMember::~WebRTCStatsMember() {

	16 }

	17

	18 WebRTCStatsReportCallback::~WebRTCStatsReportCallback() {

	19 }

	20

	21 } // namespace blink

OLD	NEW