Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(658)

Unified Diff: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp

Issue 2490163002: Reland of "Tracking reference filter mutation via SVGElementProxy" (Closed)
Patch Set: Fix double observer unregistration; simplify scope selection; add tests Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp
diff --git a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp
index a67b4ba2474a25536837507d6a14ee11147ee99a..94fbc5cda53008ab813598cd8b48e27211c42e3d 100644
--- a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp
+++ b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp
@@ -272,13 +272,6 @@ void CanvasRenderingContext2DState::resetTransform() {
m_isTransformInvertible = true;
}
-static void updateFilterReferences(HTMLCanvasElement* canvasElement,
- CanvasRenderingContext2D* context,
- const FilterOperations& filters) {
- context->clearFilterReferences();
- context->addFilterReferences(filters, canvasElement->document());
-}
-
sk_sp<SkImageFilter> CanvasRenderingContext2DState::getFilter(
Element* styleResolutionHost,
IntSize canvasSize,
@@ -322,8 +315,7 @@ sk_sp<SkImageFilter> CanvasRenderingContext2DState::getFilter(
m_resolvedFilter =
SkiaImageFilterBuilder::build(lastEffect, ColorSpaceDeviceRGB);
if (m_resolvedFilter) {
- updateFilterReferences(toHTMLCanvasElement(styleResolutionHost),
- context, filterStyle->filter());
+ context->updateFilterReferences(filterStyle->filter());
if (lastEffect->originTainted())
context->setOriginTainted();
}
« no previous file with comments | « third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698