Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2490153002: No line break when dollar sign follows minus (Closed)

Created:
4 years, 1 month ago by xing.xu
Modified:
4 years, 1 month ago
Reviewers:
drott, pdr., eae
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

No line break when dollar sign follows minus Spec: http://unicode.org/reports/tr14/#PR. "Many currency signs can appear on both sides, or even the middle, of a numeric expression. Therefore the line breaking algorithm, by default, does not break between PR and numbers or letters on either side." Here PR refers to: 002B PLUS SIGN 005C REVERSE SOLIDUS 00B1 PLUS-MINUS 2116 NUMERO SIGN 2212 MINUS SIGN 2213 MINUS-OR-PLUS-SIGN BUG=663542 Committed: https://crrev.com/bebd7123bbffb4d99b2e4b74c96dc394df92fa70 Cr-Commit-Position: refs/heads/master@{#431426}

Patch Set 1 #

Patch Set 2 : Fix fast/text case #

Messages

Total messages: 28 (20 generated)
xing.xu
PTAL, thanks
4 years, 1 month ago (2016-11-10 14:47:54 UTC) #11
dtapuska
On 2016/11/10 14:47:54, xing.xu wrote: > PTAL, thanks sorry I have no context in this ...
4 years, 1 month ago (2016-11-10 15:02:17 UTC) #12
pdr.
I'm not familiar with this area. I've added eae@chromium.org and drott@chromium.org as reviewers and removed ...
4 years, 1 month ago (2016-11-10 19:14:11 UTC) #17
eae
OK, LGTM
4 years, 1 month ago (2016-11-10 23:38:00 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2490153002/20001
4 years, 1 month ago (2016-11-11 00:33:01 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2490153002/20001
4 years, 1 month ago (2016-11-11 00:40:33 UTC) #24
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-11 00:47:15 UTC) #26
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 00:48:53 UTC) #28
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bebd7123bbffb4d99b2e4b74c96dc394df92fa70
Cr-Commit-Position: refs/heads/master@{#431426}

Powered by Google App Engine
This is Rietveld 408576698