Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1688)

Issue 2490113002: Worker: Replace CancellableTaskFactory with postDelayedCancellableTask (Closed)

Created:
4 years, 1 month ago by nhiroki
Modified:
4 years, 1 month ago
Reviewers:
falken, tzik
CC:
chromium-reviews, shimazu+worker_chromium.org, kinuko+worker_chromium.org, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Worker: Replace CancellableTaskFactory with postDelayedCancellableTask Before this CL, WorkerThread::ForceTerminationTask is implemented with CancellableTaskFactory that is deprecated in favor of WebTaskRunner::post(Delayed)CancellableTask. This CL removes ForceTerminationTask/CancellableTaskFactory, and instead implements the same functionality with postDelayedCancellableTask. BUG=663624 Committed: https://crrev.com/fb4c1fe6ad37005d9818c65a42728ac7179bf499 Cr-Commit-Position: refs/heads/master@{#431559}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Patch Set 3 : include platform/WebTaskRunner.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -82 lines) Patch
M third_party/WebKit/Source/core/workers/WorkerThread.h View 1 2 5 chunks +12 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThread.cpp View 1 8 chunks +31 lines, -57 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThreadTest.cpp View 9 chunks +20 lines, -19 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
nhiroki
PTAL, thanks!
4 years, 1 month ago (2016-11-10 07:26:39 UTC) #5
tzik
looks good https://codereview.chromium.org/2490113002/diff/1/third_party/WebKit/Source/core/workers/WorkerThread.h File third_party/WebKit/Source/core/workers/WorkerThread.h (right): https://codereview.chromium.org/2490113002/diff/1/third_party/WebKit/Source/core/workers/WorkerThread.h#newcode301 third_party/WebKit/Source/core/workers/WorkerThread.h:301: TaskHandle m_forcibleTerminationTaskHandle; Class members need to be ...
4 years, 1 month ago (2016-11-10 07:34:28 UTC) #8
nhiroki
Thank you. Updated. https://codereview.chromium.org/2490113002/diff/1/third_party/WebKit/Source/core/workers/WorkerThread.h File third_party/WebKit/Source/core/workers/WorkerThread.h (right): https://codereview.chromium.org/2490113002/diff/1/third_party/WebKit/Source/core/workers/WorkerThread.h#newcode301 third_party/WebKit/Source/core/workers/WorkerThread.h:301: TaskHandle m_forcibleTerminationTaskHandle; On 2016/11/10 07:34:27, tzik ...
4 years, 1 month ago (2016-11-10 07:39:52 UTC) #11
tzik
lgtm
4 years, 1 month ago (2016-11-10 07:48:52 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2490113002/40001
4 years, 1 month ago (2016-11-11 11:05:37 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-11 14:35:50 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 14:38:23 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fb4c1fe6ad37005d9818c65a42728ac7179bf499
Cr-Commit-Position: refs/heads/master@{#431559}

Powered by Google App Engine
This is Rietveld 408576698