Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2490103002: Add mapping entry for newer DualShock 4 model (Closed)

Created:
4 years, 1 month ago by cgutman
Modified:
4 years, 1 month ago
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add mapping entry for newer DualShock 4 model This gamepad shipped with the PlayStation 4 Slim. It has the same mapping as the original DualShock 4 but a different PID. BUG=664030 TEST=http://html5gamepad.com Committed: https://crrev.com/1018bb702883f08b560a30c5be2acc9aa9c85a6e Cr-Commit-Position: refs/heads/master@{#431216}

Patch Set 1 #

Patch Set 2 : Differentiate new DS4 model with comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M device/gamepad/gamepad_standard_mappings_linux.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M device/gamepad/gamepad_standard_mappings_mac.mm View 1 1 chunk +1 line, -0 lines 0 comments Download
M device/gamepad/gamepad_standard_mappings_win.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
cgutman
Here's a trivial mapping update adding the PID of the newer DualShock 4 model.
4 years, 1 month ago (2016-11-10 07:05:56 UTC) #3
bajones
On 2016/11/10 07:05:56, cgutman wrote: > Here's a trivial mapping update adding the PID of ...
4 years, 1 month ago (2016-11-10 07:44:48 UTC) #5
cgutman
On 2016/11/10 07:44:48, bajones wrote: > On 2016/11/10 07:05:56, cgutman wrote: > > Here's a ...
4 years, 1 month ago (2016-11-10 08:03:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2490103002/20001
4 years, 1 month ago (2016-11-10 08:12:09 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-10 09:08:46 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 09:11:52 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1018bb702883f08b560a30c5be2acc9aa9c85a6e
Cr-Commit-Position: refs/heads/master@{#431216}

Powered by Google App Engine
This is Rietveld 408576698