Migrate opt-in auth flow to re-auth flow.

chrome/browser/chromeos/arc/arc_auth_service_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <memory>
 #include <string>
 #include <vector>
 
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 26 matching lines @@
 #include "components/user_manager/user_names.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "google_apis/gaia/gaia_constants.h"
 #include "google_apis/gaia/gaia_urls.h"
 #include "net/http/http_status_code.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace arc {
 
-namespace {
-
-const char kTestAuthCode[] = "4/Qa3CPIhh-WcMfWSf9HZaYcGUhEeax-F9sQK9CNRhZWs";
-
-}  // namespace
-
 class ArcAuthServiceTest : public testing::Test {
  public:
   ArcAuthServiceTest()
       : thread_bundle_(content::TestBrowserThreadBundle::IO_MAINLOOP),
         user_manager_enabler_(new chromeos::FakeChromeUserManager) {}
   ~ArcAuthServiceTest() override = default;
 
   void SetUp() override {
     chromeos::DBusThreadManager::Initialize();
 
@@ skipping 116 matching lines @@
   auth_service()->OnPrimaryUserProfilePrepared(profile());
   ASSERT_EQ(ArcAuthService::State::NOT_INITIALIZED, auth_service()->state());
 
   // Correctly stop service.
   auth_service()->Shutdown();
 }
 
 TEST_F(ArcAuthServiceTest, BaseWorkflow) {
   ASSERT_FALSE(bridge_service()->ready());
   ASSERT_EQ(ArcAuthService::State::NOT_INITIALIZED, auth_service()->state());
-  ASSERT_EQ(std::string(), auth_service()->GetAndResetAuthCode());
 
   auth_service()->OnPrimaryUserProfilePrepared(profile());
 
   // By default ARC is not enabled.
   ASSERT_EQ(ArcAuthService::State::STOPPED, auth_service()->state());
 
   profile()->GetPrefs()->SetBoolean(prefs::kArcEnabled, true);
 
   // Setting profile and pref initiates a code fetching process.
   ASSERT_EQ(ArcAuthService::State::SHOWING_TERMS_OF_SERVICE,
             auth_service()->state());
 
-  // TODO(hidehiko): Verify state transition from SHOWINING_TERMS_OF_SERVICE ->
-  // CHECKING_ANDROID_MANAGEMENT -> FETCHING_CODE, when we extract
-  // ArcSessionManager.
-  auth_service()->SetAuthCodeAndStartArc(kTestAuthCode);
+  // TODO(hidehiko): Verify state transition from SHOWING_TERMS_OF_SERVICE ->
+  // CHECKING_ANDROID_MANAGEMENT, when we extract ArcSessionManager.
+  auth_service()->StartArc();
 
   ASSERT_EQ(ArcAuthService::State::ACTIVE, auth_service()->state());
   ASSERT_TRUE(bridge_service()->ready());
-  // Auth code valid only for one call.
-  ASSERT_EQ(kTestAuthCode, auth_service()->GetAndResetAuthCode());
-  ASSERT_EQ(std::string(), auth_service()->GetAndResetAuthCode());
 
   auth_service()->Shutdown();
   ASSERT_EQ(ArcAuthService::State::NOT_INITIALIZED, auth_service()->state());
   ASSERT_FALSE(bridge_service()->ready());
-  ASSERT_EQ(std::string(), auth_service()->GetAndResetAuthCode());
 
   // Send profile and don't provide a code.
   auth_service()->OnPrimaryUserProfilePrepared(profile());
 
   // Setting profile initiates a code fetching process.
   ASSERT_EQ(ArcAuthService::State::SHOWING_TERMS_OF_SERVICE,
             auth_service()->state());
 
   content::BrowserThread::GetBlockingPool()->FlushForTesting();
   base::RunLoop().RunUntilIdle();
@@ skipping 21 matching lines @@
   // Correctly stop service.
   auth_service()->Shutdown();
 }
 
 TEST_F(ArcAuthServiceTest, CloseUIKeepsArcEnabled) {
   PrefService* const pref = profile()->GetPrefs();
 
   auth_service()->OnPrimaryUserProfilePrepared(profile());
   pref->SetBoolean(prefs::kArcEnabled, true);
 
-  auth_service()->SetAuthCodeAndStartArc(kTestAuthCode);
+  auth_service()->StartArc();
 
   ASSERT_EQ(ArcAuthService::State::ACTIVE, auth_service()->state());
 
   auth_service()->CancelAuthCode();
   ASSERT_EQ(ArcAuthService::State::ACTIVE, auth_service()->state());
   ASSERT_TRUE(pref->GetBoolean(prefs::kArcEnabled));
 
   // Correctly stop service.
   auth_service()->Shutdown();
 }
@@ skipping 14 matching lines @@
 
 TEST_F(ArcAuthServiceTest, SignInStatus) {
   PrefService* const prefs = profile()->GetPrefs();
 
   EXPECT_FALSE(prefs->GetBoolean(prefs::kArcSignedIn));
   prefs->SetBoolean(prefs::kArcEnabled, true);
 
   auth_service()->OnPrimaryUserProfilePrepared(profile());
   EXPECT_EQ(ArcAuthService::State::SHOWING_TERMS_OF_SERVICE,
             auth_service()->state());
-  auth_service()->SetAuthCodeAndStartArc(kTestAuthCode);
+  auth_service()->StartArc();
   EXPECT_EQ(ArcAuthService::State::ACTIVE, auth_service()->state());
   EXPECT_TRUE(bridge_service()->ready());
   EXPECT_FALSE(prefs->GetBoolean(prefs::kArcSignedIn));
   auth_service()->OnSignInComplete();
   EXPECT_TRUE(prefs->GetBoolean(prefs::kArcSignedIn));
   EXPECT_EQ(ArcAuthService::State::ACTIVE, auth_service()->state());
   EXPECT_TRUE(bridge_service()->ready());
 
   // Second start, no fetching code is expected.
   auth_service()->Shutdown();
@@ skipping 15 matching lines @@
 
   // Correctly stop service.
   auth_service()->Shutdown();
 }
 
 TEST_F(ArcAuthServiceTest, DisabledForDeviceLocalAccount) {
   PrefService* const prefs = profile()->GetPrefs();
   EXPECT_FALSE(prefs->GetBoolean(prefs::kArcSignedIn));
   prefs->SetBoolean(prefs::kArcEnabled, true);
   auth_service()->OnPrimaryUserProfilePrepared(profile());
-  auth_service()->SetAuthCodeAndStartArc(kTestAuthCode);
+  auth_service()->StartArc();
   EXPECT_EQ(ArcAuthService::State::ACTIVE, auth_service()->state());
 
   // Create device local account and set it as active.
   const std::string email = "device-local-account@fake-email.com";
   TestingProfile::Builder profile_builder;
   profile_builder.SetProfileName(email);
   std::unique_ptr<TestingProfile> device_local_profile(profile_builder.Build());
   const AccountId account_id(AccountId::FromUserEmail(email));
   GetFakeUserManager()->AddPublicAccountUser(account_id);
 
   // Remove |profile_| to set the device local account be the primary account.
   GetFakeUserManager()->RemoveUserFromList(
       multi_user_util::GetAccountIdFromProfile(profile()));
   GetFakeUserManager()->LoginUser(account_id);
 
   // Check that user without GAIA account can't use ARC.
   device_local_profile->GetPrefs()->SetBoolean(prefs::kArcEnabled, true);
   auth_service()->OnPrimaryUserProfilePrepared(device_local_profile.get());
   EXPECT_EQ(ArcAuthService::State::NOT_INITIALIZED, auth_service()->state());
 
   // Correctly stop service.
   auth_service()->Shutdown();
 }
 
 TEST_F(ArcAuthServiceTest, DisabledForNonPrimaryProfile) {
   profile()->GetPrefs()->SetBoolean(prefs::kArcEnabled, true);
   auth_service()->OnPrimaryUserProfilePrepared(profile());
-  auth_service()->SetAuthCodeAndStartArc(kTestAuthCode);
+  auth_service()->StartArc();
   EXPECT_EQ(ArcAuthService::State::ACTIVE, auth_service()->state());
 
   // Create a second profile and set it as the active profile.
   const std::string email = "test@example.com";
   TestingProfile::Builder profile_builder;
   profile_builder.SetProfileName(email);
   std::unique_ptr<TestingProfile> second_profile(profile_builder.Build());
   const AccountId account_id(AccountId::FromUserEmail(email));
   GetFakeUserManager()->AddUser(account_id);
   GetFakeUserManager()->SwitchActiveUser(account_id);
   second_profile->GetPrefs()->SetBoolean(prefs::kArcEnabled, true);
 
   // Check that non-primary user can't use Arc.
   EXPECT_FALSE(chromeos::ProfileHelper::IsPrimaryProfile(second_profile.get()));
   EXPECT_FALSE(ArcAppListPrefs::Get(second_profile.get()));
 
   auth_service()->Shutdown();
 }
 
 }  // namespace arc