Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 2490083002: Add a use counter to customElements.define. (Closed)

Created:
4 years, 1 month ago by dominicc (has gone to gerrit)
Modified:
4 years, 1 month ago
CC:
asvitkine+watch_chromium.org, blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, dominicc+watchlist_chromium.org, eae+blinkwatch, rwlbuis, sof, webcomponents-bugzilla_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a use counter to customElements.define. BUG=664001 Committed: https://crrev.com/cc55b22c21045a945d284f20373f973aa5aebb2b Cr-Commit-Position: refs/heads/master@{#432806}

Patch Set 1 #

Patch Set 2 : Bring patch to head. #

Patch Set 3 : Bring patch to head. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/Source/core/dom/custom/CustomElementRegistry.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 28 (17 generated)
dominicc (has gone to gerrit)
PTAL
4 years, 1 month ago (2016-11-10 03:58:31 UTC) #4
tkent
lgtm
4 years, 1 month ago (2016-11-11 01:12:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2490083002/20001
4 years, 1 month ago (2016-11-16 02:15:41 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/305214)
4 years, 1 month ago (2016-11-16 02:33:20 UTC) #15
dominicc (has gone to gerrit)
jochen, can I haz LGTM for adding this use counter? Wendy Ginsberg wants to track ...
4 years, 1 month ago (2016-11-16 02:34:13 UTC) #17
jochen (gone - plz use gerrit)
lgtm
4 years, 1 month ago (2016-11-17 01:57:46 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2490083002/20001
4 years, 1 month ago (2016-11-17 06:09:11 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/274411) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 1 month ago (2016-11-17 06:11:37 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2490083002/40001
4 years, 1 month ago (2016-11-17 06:15:29 UTC) #25
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-17 08:16:15 UTC) #26
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 08:17:58 UTC) #28
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/cc55b22c21045a945d284f20373f973aa5aebb2b
Cr-Commit-Position: refs/heads/master@{#432806}

Powered by Google App Engine
This is Rietveld 408576698