|
|
Chromium Code Reviews|
Created:
4 years, 1 month ago by dominicc (has gone to gerrit) Modified:
4 years, 1 month ago CC:
asvitkine+watch_chromium.org, blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, dominicc+watchlist_chromium.org, eae+blinkwatch, rwlbuis, sof, webcomponents-bugzilla_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd a use counter to customElements.define.
BUG=664001
Committed: https://crrev.com/cc55b22c21045a945d284f20373f973aa5aebb2b
Cr-Commit-Position: refs/heads/master@{#432806}
Patch Set 1 #Patch Set 2 : Bring patch to head. #Patch Set 3 : Bring patch to head. #
Messages
Total messages: 28 (17 generated)
The CQ bit was checked by dominicc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
dominicc@chromium.org changed reviewers: + tkent@chromium.org
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by dominicc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by dominicc@chromium.org
The CQ bit was checked by dominicc@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org Link to the patchset: https://codereview.chromium.org/2490083002/#ps20001 (title: "Bring patch to head.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
dominicc@chromium.org changed reviewers: + jochen@chromium.org
jochen, can I haz LGTM for adding this use counter? Wendy Ginsberg wants to track uptake of customElements.define against the decline of document.register which we already have a counter for. kthx!
lgtm
The CQ bit was checked by dominicc@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by dominicc@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org, jochen@chromium.org Link to the patchset: https://codereview.chromium.org/2490083002/#ps40001 (title: "Bring patch to head.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Add a use counter to customElements.define. BUG=664001 ========== to ========== Add a use counter to customElements.define. BUG=664001 Committed: https://crrev.com/cc55b22c21045a945d284f20373f973aa5aebb2b Cr-Commit-Position: refs/heads/master@{#432806} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/cc55b22c21045a945d284f20373f973aa5aebb2b Cr-Commit-Position: refs/heads/master@{#432806} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
