Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Unified Diff: ui/views/widget/native_widget_mac_accessibility_unittest.mm

Issue 2490073002: MacViews/a11y: Allow accessibility clients to focus and unfocus focusable Views. (Closed)
Patch Set: Fix test. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/accessibility/native_view_accessibility_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/widget/native_widget_mac_accessibility_unittest.mm
diff --git a/ui/views/widget/native_widget_mac_accessibility_unittest.mm b/ui/views/widget/native_widget_mac_accessibility_unittest.mm
index f87d0dbfe90aa1b89557577f56f993c740548004..3d641d190f9eab41fa0d4a97d726766736902263 100644
--- a/ui/views/widget/native_widget_mac_accessibility_unittest.mm
+++ b/ui/views/widget/native_widget_mac_accessibility_unittest.mm
@@ -304,11 +304,42 @@ TEST_F(NativeWidgetMacAccessibilityTest, TextfieldEditableAttributes) {
NSAccessibilityVisibleCharacterRangeAttribute) rangeValue]));
}
-// Test writing accessibility attributes via an accessibility client.
+// Test writing accessibility attributes via an accessibility client for normal
+// Views.
+TEST_F(NativeWidgetMacAccessibilityTest, ViewWritableAttributes) {
+ FlexibleRoleTestView* view = new FlexibleRoleTestView(ui::AX_ROLE_GROUP);
+ view->SetSize(GetWidgetBounds().size());
+ widget()->GetContentsView()->AddChildView(view);
+
+ // Get the FlexibleRoleTestView accessibility object.
+ NSPoint midpoint = gfx::ScreenPointToNSPoint(GetWidgetBounds().CenterPoint());
+ id ax_node = [widget()->GetNativeWindow() accessibilityHitTest:midpoint];
+ EXPECT_TRUE(ax_node);
+
+ // Make sure it's the correct accessibility object.
+ id value = [ax_node accessibilityAttributeValue:NSAccessibilityRoleAttribute];
+ EXPECT_NSEQ(NSAccessibilityGroupRole, value);
+
+ // Make sure |view| is focusable, then focus/unfocus it.
+ view->SetFocusBehavior(View::FocusBehavior::ALWAYS);
+ EXPECT_FALSE(view->HasFocus());
+ EXPECT_FALSE(
+ [AttributeValueAtMidpoint(NSAccessibilityFocusedAttribute) boolValue]);
+ EXPECT_TRUE([ax_node
+ accessibilityIsAttributeSettable:NSAccessibilityFocusedAttribute]);
+ [ax_node accessibilitySetValue:[NSNumber numberWithBool:YES]
+ forAttribute:NSAccessibilityFocusedAttribute];
+ EXPECT_TRUE(
+ [AttributeValueAtMidpoint(NSAccessibilityFocusedAttribute) boolValue]);
+ EXPECT_TRUE(view->HasFocus());
+}
+
+// Test writing accessibility attributes via an accessibility client for
+// editable controls (in this case, views::Textfields).
TEST_F(NativeWidgetMacAccessibilityTest, TextfieldWritableAttributes) {
Textfield* textfield = AddChildTextfield(GetWidgetBounds().size());
- // Get the textfield accessibility object.
+ // Get the Textfield accessibility object.
NSPoint midpoint = gfx::ScreenPointToNSPoint(GetWidgetBounds().CenterPoint());
id ax_node = [widget()->GetNativeWindow() accessibilityHitTest:midpoint];
EXPECT_TRUE(ax_node);
« no previous file with comments | « ui/views/accessibility/native_view_accessibility_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698