MacViews/a11y: Allow accessibility clients to focus and unfocus focusable Views.

ui/views/widget/native_widget_mac_accessibility_unittest.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <memory>
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/strings/sys_string_conversions.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 286 matching lines @@
   EXPECT_EQ(selection_range,
             gfx::Range([AttributeValueAtMidpoint(
                 NSAccessibilitySelectedTextRangeAttribute) rangeValue]));
 
   // NSAccessibilityVisibleCharacterRangeAttribute.
   EXPECT_EQ(gfx::Range(0, kTestStringValue.length),
             gfx::Range([AttributeValueAtMidpoint(
                 NSAccessibilityVisibleCharacterRangeAttribute) rangeValue]));
 }
 
-// Test writing accessibility attributes via an accessibility client.
+// Test writing accessibility attributes via an accessibility client for normal
+// Views.
+TEST_F(NativeWidgetMacAccessibilityTest, ViewWritableAttributes) {
+  FlexibleRoleTestView* view = new FlexibleRoleTestView(ui::AX_ROLE_GROUP);
+  view->SetSize(GetWidgetBounds().size());
+  widget()->GetContentsView()->AddChildView(view);
+
+  // Get the FlexibleRoleTestView accessibility object.
+  NSPoint midpoint = gfx::ScreenPointToNSPoint(GetWidgetBounds().CenterPoint());
+  id ax_node = [widget()->GetNativeWindow() accessibilityHitTest:midpoint];
+  EXPECT_TRUE(ax_node);
+
+  // Make sure it's the correct accessibility object.
+  id value = [ax_node accessibilityAttributeValue:NSAccessibilityRoleAttribute];
+  EXPECT_NSEQ(NSAccessibilityGroupRole, value);
+
+  // Make sure |view| is focusable, then focus/unfocus it.
+  view->SetFocusBehavior(ClientView::FocusBehavior::ALWAYS);

[tapted, 2016/11/11 00:36:25]

ClientView -> View

[Patti Lor, 2016/11/14 03:51:21]

Done.

+  EXPECT_FALSE(view->HasFocus());
+  EXPECT_EQ(NO, [AttributeValueAtMidpoint(NSAccessibilityFocusedAttribute)

[tapted, 2016/11/11 00:36:25]

nit: I think I'd prefer EXPECT_FALSE rather than EXPECT_EQ(NO. 

[Patti Lor, 2016/11/14 03:51:21]

Done.

+                    boolValue]);
+  EXPECT_TRUE([ax_node
+      accessibilityIsAttributeSettable:NSAccessibilityFocusedAttribute]);
+  [ax_node accessibilitySetValue:[NSNumber numberWithBool:YES]
+                    forAttribute:NSAccessibilityFocusedAttribute];
+  EXPECT_EQ(YES, [AttributeValueAtMidpoint(NSAccessibilityFocusedAttribute)

[tapted, 2016/11/11 00:36:25]

nit: EXPECT_TRUE

[Patti Lor, 2016/11/14 03:51:21]

Done.

+                     boolValue]);
+  EXPECT_TRUE(view->HasFocus());
+}
+
+// Test writing accessibility attributes via an accessibility client for
+// editable controls (in this case, views::Textfields).
 TEST_F(NativeWidgetMacAccessibilityTest, TextfieldWritableAttributes) {
   Textfield* textfield = AddChildTextfield(GetWidgetBounds().size());
 
-  // Get the textfield accessibility object.
+  // Get the Textfield accessibility object.
   NSPoint midpoint = gfx::ScreenPointToNSPoint(GetWidgetBounds().CenterPoint());
   id ax_node = [widget()->GetNativeWindow() accessibilityHitTest:midpoint];
   EXPECT_TRUE(ax_node);
 
   // Make sure it's the correct accessibility object.
   id value =
       [ax_node accessibilityAttributeValue:NSAccessibilityValueAttribute];
   EXPECT_NSEQ(kTestStringValue, value);
 
   // Write a new NSAccessibilityValueAttribute.
@@ skipping 54 matching lines @@
                     forAttribute:NSAccessibilitySelectedTextAttribute];
   EXPECT_NSEQ(new_string,
               AttributeValueAtMidpoint(NSAccessibilityValueAttribute));
   EXPECT_EQ(base::SysNSStringToUTF16(new_string), textfield->text());
   // Make sure the cursor is at the end of the replacement.
   EXPECT_EQ(gfx::Range(front.length() + replacement.length()),
             textfield->GetSelectedRange());
 }
 
 }  // namespace views