MacViews/a11y: Allow accessibility clients to focus and unfocus focusable Views.

ui/views/accessibility/native_view_accessibility_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "base/memory/ptr_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "ui/accessibility/ax_node_data.h"
 #include "ui/gfx/geometry/rect_conversions.h"
 #include "ui/views/accessibility/native_view_accessibility.h"
 #include "ui/views/controls/button/button.h"
 #include "ui/views/controls/label.h"
 #include "ui/views/test/views_test_base.h"
 
 namespace views {
 namespace test {
@@ skipping 65 matching lines @@
 }
 
 TEST_F(NativeViewAccessibilityTest, LabelIsChildOfButton) {
   EXPECT_EQ(1, button_accessibility_->GetChildCount());
   EXPECT_EQ(label_->GetNativeViewAccessible(),
             button_accessibility_->ChildAtIndex(0));
   EXPECT_EQ(button_->GetNativeViewAccessible(),
             label_accessibility_->GetParent());
 }
 
+TEST_F(NativeViewAccessibilityTest, WritableFocus) {
+  // Dealing with focus here, so add things into a Widget.
+  std::unique_ptr<Widget> widget = base::MakeUnique<Widget>();

[tapted, 2016/11/11 00:36:25]

NativeViewAccessibilityTest already has a |widget_| member - can we use that (or
explain why not in the comment above). E.g. I think it would be nicer to do

widget_->GetContentsView()->AddChildView(button_);
rather than
widget_->SetContentsView(button_);

in SetUp(), assuming nothing else breaks

(maybe also change TYPE_WINDOW_FRAMELESS if you need to).

[Patti Lor, 2016/11/14 03:51:21]

Ah, thank you! I think it got all mixed up in a rebase. Fixed now :)

+  Widget::InitParams params = CreateParams(Widget::InitParams::TYPE_WINDOW);
+  params.ownership = Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
+  widget->Init(params);
+  widget->GetContentsView()->AddChildView(button_);
+  widget->Show();
+
+  // Make |button_| focusable, and focus/unfocus it via NativeViewAccessibility.
+  button_->SetFocusBehavior(ClientView::FocusBehavior::ALWAYS);

[tapted, 2016/11/11 00:36:25]

ClientView -> View

[Patti Lor, 2016/11/14 03:51:21]

Done.

+  EXPECT_EQ(nullptr, button_->GetFocusManager()->GetFocusedView());
+  EXPECT_EQ(nullptr, button_accessibility_->GetFocus());
+  EXPECT_TRUE(button_accessibility_->SetFocused(true));
+  EXPECT_EQ(button_, button_->GetFocusManager()->GetFocusedView());
+  EXPECT_EQ(button_->GetNativeViewAccessible(),
+            button_accessibility_->GetFocus());
+  EXPECT_TRUE(button_accessibility_->SetFocused(false));
+  EXPECT_EQ(nullptr, button_->GetFocusManager()->GetFocusedView());
+  EXPECT_EQ(nullptr, button_accessibility_->GetFocus());
+
+  // If not focusable at all, SetFocused() should return false.
+  button_->SetEnabled(false);
+  EXPECT_FALSE(button_accessibility_->SetFocused(true));
+
+  // Avoid deleting |label_|/|button_| twice since they're already unique_ptrs.
+  widget->GetContentsView()->RemoveChildView(button_);

[tapted, 2016/11/11 00:36:25]

this shouldn't be necessary... And I'm not sure that button_ is a unique_ptr.
Perhaps it's a lifetime problem with things done in TearDown, and re-using
|widget_| will help.

[Patti Lor, 2016/11/14 03:51:21]

Yep, not necessary - originally had it that way in an older version of this CL.
Removed now.

+}
+
 // Subclass of NativeViewAccessibility that destroys itself when its
 // parent widget is destroyed, for the purposes of making sure this
 // doesn't lead to a crash.
 class TestNativeViewAccessibility : public NativeViewAccessibility {
  public:
   explicit TestNativeViewAccessibility(View* view)
       : NativeViewAccessibility(view) {}
 
   void OnWidgetDestroying(Widget* widget) override {
     bool is_destroying_parent_widget = (parent_widget_ == widget);
@@ skipping 18 matching lines @@
   // WidgetObserver. Note that TestNativeViewAccessibility is a subclass
   // defined above that destroys itself when its parent widget is destroyed.
   TestNativeViewAccessibility* child_accessible =
       new TestNativeViewAccessibility(child_widget->GetRootView());
   child_accessible->SetParentWidget(parent_widget.get());
   parent_widget.reset();
 }
 
 }  // namespace test
 }  // namespace views