MacViews/a11y: Allow accessibility clients to focus and unfocus focusable Views.

ui/views/accessibility/native_view_accessibility.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/accessibility/native_view_accessibility.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "build/build_config.h"
 #include "ui/accessibility/ax_action_data.h"
 #include "ui/accessibility/ax_node_data.h"
@@ skipping 53 matching lines @@
     return data_;
   }
 
   view_->GetAccessibleNodeData(&data_);
   data_.location = gfx::RectF(view_->GetBoundsInScreen());
   base::string16 description;
   view_->GetTooltipText(gfx::Point(), &description);
   data_.AddStringAttribute(ui::AX_ATTR_DESCRIPTION,
                            base::UTF16ToUTF8(description));
 
-  data_.state |= (1 << ui::AX_STATE_FOCUSABLE);
+  if (view_->IsFocusable())

[tapted, 2016/11/11 00:36:25]

would IsAccessibilityFocusable be more appropriate here?

I lean towards, "yes", but only if it works, even when Full Keyboard Access
isn't enabled in preferences. (e.g. normally buttons don't get focus in regular
tab traversal without full keyboard access, but requesting focus may still give
it focus in that case)

[Patti Lor, 2016/11/14 03:51:21]

Oh, I hadn't thought about that, thanks for pointing it out. I just did a quick
test and it looks like Cocoa controls do what you've described in your example,
so have changed it to use IsAccessibilityFocusable().

+    data_.state |= (1 << ui::AX_STATE_FOCUSABLE);
 
   if (!view_->enabled())
     data_.state |= (1 << ui::AX_STATE_DISABLED);
 
   if (!view_->visible())
     data_.state |= (1 << ui::AX_STATE_INVISIBLE);
 
   return data_;
 }
 
@@ skipping 125 matching lines @@
   action_data.value = new_value;
   action_data.action = clear_first ? ui::AX_ACTION_SET_VALUE
       : ui::AX_ACTION_REPLACE_SELECTED_TEXT;
   return view_->HandleAccessibleAction(action_data);
 }
 
 bool NativeViewAccessibility::CanSetStringValue() {
   return !ui::AXNodeData::IsFlagSet(GetData().state, ui::AX_STATE_READ_ONLY);
 }
 
+bool NativeViewAccessibility::SetFocused(const bool focused) {
+  if (!ui::AXNodeData::IsFlagSet(GetData().state, ui::AX_STATE_FOCUSABLE))
+    return false;
+
+  if (focused == view_->HasFocus())
+    return true;
+  if (focused)
+    view_->RequestFocus();
+  else

[tapted, 2016/11/11 00:36:25]

optional: I'd maybe make this `else if view->HasFocus()` and remove the early
exit above. It's clearer that way ClearFocus() isn't accidentally called when a
different view has focus

[Patti Lor, 2016/11/14 03:51:21]

Done, thanks!

+    view_->GetFocusManager()->ClearFocus();
+  return true;
+}
+
 void NativeViewAccessibility::OnWidgetDestroying(Widget* widget) {
   if (parent_widget_ == widget) {
     parent_widget_->RemoveObserver(this);
     parent_widget_ = nullptr;
   }
 }
 
 void NativeViewAccessibility::SetParentWidget(Widget* parent_widget) {
   if (parent_widget_)
     parent_widget_->RemoveObserver(this);
@@ skipping 30 matching lines @@
               child_widget_platform_node->GetDelegate());
       if (child_widget_view_accessibility->parent_widget() != widget)
         child_widget_view_accessibility->SetParentWidget(widget);
     }
 
     result_child_widgets->push_back(child_widget);
   }
 }
 
 }  // namespace views