MacViews/a11y: Allow accessibility clients to focus and unfocus focusable Views.

ui/accessibility/platform/ax_platform_node_mac.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ui/accessibility/platform/ax_platform_node_mac.h"
 
 #import <Cocoa/Cocoa.h>
 #include <stddef.h>
 
 #include "base/macros.h"
@@ skipping 365 matching lines @@
           isEqualToString:NSAccessibilityVisibleCharacterRangeAttribute]) {
     return NO;
   }
 
   if ([attributeName isEqualToString:NSAccessibilityValueAttribute] ||
       [attributeName isEqualToString:NSAccessibilitySelectedTextAttribute])
     return node_->GetDelegate()->CanSetStringValue();
 
   if ([attributeName isEqualToString:NSAccessibilityFocusedAttribute]) {
     if (ui::AXNodeData::IsFlagSet(node_->GetData().state,
                                   ui::AX_STATE_FOCUSABLE))

[tapted, 2016/11/11 00:36:25]

nit: needs curlies now that the block below goes over 2 lines, but.. can we
instead just remove the `if` and always return?  (otherwise, just `return YES;`
below)

[Patti Lor, 2016/11/14 03:51:21]

Oops, yeah this is definitely a mistake. Fixed now. Thanks!

-      return NO;
+      return ui::AXNodeData::IsFlagSet(node_->GetData().state,
+                                       ui::AX_STATE_FOCUSABLE);
   }
 
   // TODO(patricialor): Add callbacks for updating the above attributes except
   // NSAccessibilityValueAttribute and return YES.
   return NO;
 }
 
 - (void)accessibilitySetValue:(id)value forAttribute:(NSString*)attribute {
-  if ([attribute isEqualToString:NSAccessibilityValueAttribute] &&
-      [value isKindOfClass:[NSString class]]) {
-    node_->GetDelegate()->SetStringValue(base::SysNSStringToUTF16(value), true);
-  } else if ([attribute isEqualToString:NSAccessibilitySelectedTextAttribute] &&
-             [value isKindOfClass:[NSString class]]) {
-    node_->GetDelegate()->SetStringValue(base::SysNSStringToUTF16(value),
-                                         false);
+  if ([value isKindOfClass:[NSString class]]) {
+    if ([attribute isEqualToString:NSAccessibilityValueAttribute]) {
+      node_->GetDelegate()->SetStringValue(base::SysNSStringToUTF16(value),
+                                           true);
+    } else if ([attribute
+                   isEqualToString:NSAccessibilitySelectedTextAttribute]) {
+      node_->GetDelegate()->SetStringValue(base::SysNSStringToUTF16(value),
+                                           false);
+    }
+  } else if ([value isKindOfClass:[NSNumber class]]) {
+    if ([attribute isEqualToString:NSAccessibilityFocusedAttribute]) {
+      node_->GetDelegate()->SetFocused([value boolValue]);
+    }
   }
 
   // TODO(patricialor): Plumb through all the other writable attributes as
   // specified in accessibilityIsAttributeSettable.
 }
 
 - (id)accessibilityAttributeValue:(NSString*)attribute {
   SEL selector = NSSelectorFromString(attribute);
   if ([self respondsToSelector:selector])
     return [self performSelector:selector];
@@ skipping 171 matching lines @@
   }
   NotifyMacEvent(native_node_, event_type);
 }
 
 int AXPlatformNodeMac::GetIndexInParent() {
   // TODO(dmazzoni): implement this.  http://crbug.com/396137
   return -1;
 }
 
 }  // namespace ui