Issue 2490023003: Add File.lengthSync to use it for FileByteStore eviction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2490023003: Add File.lengthSync to use it for FileByteStore eviction. (Closed)

Created:
4 years, 1 month ago by scheglov

Modified:
4 years, 1 month ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+53 lines, -1 line)			Patch
M	pkg/analyzer/lib/file_system/file_system.dart	View	1 chunk	+7 lines, -1 line	0 comments	Download
M	pkg/analyzer/lib/file_system/memory_file_system.dart	View	2 chunks	+10 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/file_system/physical_file_system.dart	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	pkg/analyzer/test/file_system/memory_file_system_test.dart	View	1 chunk	+14 lines, -0 lines	0 comments	Download
M	pkg/analyzer/test/file_system/physical_resource_provider_test.dart	View	1 chunk	+13 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Brian Wilkerson

The changes lgtm, but I don't understand how you're planning on using them.

4 years, 1 month ago (2016-11-10 21:17:21 UTC) #2

scheglov

4 years, 1 month ago (2016-11-10 21:31:13 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
891e709c5fb6f0ba3a91eccdb62a58bea2d3ecf6 (presubmit successful).