Here's a first draft of a bot script for running the DDC tests.

Here's a first draft of a bot script for running the DDC tests.

As you can see, it requires "npm" to already be installed. Travis, I
think already has that on images. How should we handle this on the
Chrome bots?

What else did I do here that's wrong?

R=whesse@google.com

Committed: https://github.com/dart-lang/sdk/commit/1383286a35676287aa77891f41eabb837193e0db

[Bob Nystrom, 2016-11-09 23:22:29]

rnystrom@google.com changed reviewers:
+ whesse@google.com

[Bill Hesse, 2016-11-10 12:26:18]

lgtm

This looks good.  I will install npm on the slaves that run the DDC test
builders.  The linux one is a compute engine machine, that gets reimaged
periodically, so we will need to either switch that to a physical machine, or
add npm to the reimaging.

Because this is running as a step in a recipe (the new way of running builders),
the BuildStep calls may not have any effect (the @@@ message they put in is
commented out).

So you can just run subprocesses with the python process module, but the
RunProcess calls used here should be even better.

I'll get npm up on the machines, and then you can land this.  I can also do a
trial run before you land, by uploading to a private branch on dart-lang/sdk,
and running, if you want.  But it should be fine to commit, as well.

[Bill Hesse, 2016-11-10 18:25:45]

https://codereview.chromium.org/2490013003/diff/1/tools/bots/ddc_tests.py
File tools/bots/ddc_tests.py (right):

https://codereview.chromium.org/2490013003/diff/1/tools/bots/ddc_tests.py#new...
tools/bots/ddc_tests.py:29: bot.RunProcess(['dart', 'test/all_tests.dart'])
You need to say which dart executable you want to use.  There is a helper
function to get the checked in dart executable from the SDK repo.

utils.CheckedInSdkExecutable()

The utils object is created by import bot_utils.

[Bob Nystrom, 2016-11-10 18:41:05]

Description was changed from

==========
Here's a first draft of a bot script for running the DDC tests.

As you can see, it requires "npm" to already be installed. Travis, I
think already has that on images. How should we handle this on the
Chrome bots?

What else did I do here that's wrong?
==========

to

==========
Here's a first draft of a bot script for running the DDC tests.

As you can see, it requires "npm" to already be installed. Travis, I
think already has that on images. How should we handle this on the
Chrome bots?

What else did I do here that's wrong?

R=whesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/1383286a35676287aa77891f41eabb837193e0db
==========

[Bob Nystrom, 2016-11-10 18:41:06]

Committed patchset #1 (id:1) manually as
1383286a35676287aa77891f41eabb837193e0db (presubmit successful).