[MR UI] Make custom controls / extensionview in the dialog taller by 6px

[MR UI] Make custom controls / extensionview in the dialog taller by 6px

This change makes the custom controls taller, so that the custom controls for
YouTube, etc aren't clipped.

BUG=630294
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/5cf820b69968e571dc962e04ec91750e69843134
Cr-Commit-Position: refs/heads/master@{#431998}

[takumif, 2016-11-10 22:02:37]

Description was changed from

==========
.

BUG=
==========

to

==========
.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[takumif, 2016-11-10 22:46:43]

Description was changed from

==========
.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MR UI] Make custom controls / extensionview in the dialog taller by 6px

This change makes the custom controls taller, so that the custom controls for
YouTube, etc aren't clipped.

BUG=630294
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[takumif, 2016-11-10 22:46:43]

takumif@chromium.org changed reviewers:
+ apacible@chromium.org, vadimgo@chromium.org

[apacible, 2016-11-11 17:59:52]

How does this look for shorter custom controls?

There was also some discussion about allowing the provider to send the necessary
height for the custom controls. What was the outcome of that discussion?

nit: "controls" in title is misspelled.

[takumif, 2016-11-11 19:22:43]

On 2016/11/11 17:59:52, apacible wrote:
> How does this look for shorter custom controls?
Uploaded screenshots:
https://drive.google.com/drive/folders/0BxrKSYHNwjQGbmVfMjZEcm5vdDQ?usp=sharing
The bottom margin for the extensionview will be 2px smaller than it was before
its top margin was increased.

> 
> There was also some discussion about allowing the provider to send the
necessary
> height for the custom controls. What was the outcome of that discussion?
I looked into it and it seemed that the host can tell the extensionview to
change the size of the contents inside, but not the other way around.

> 
> nit: "controls" in title is misspelled.
Oops. Fixed.

[apacible, 2016-11-11 22:55:27]

On 2016/11/11 19:22:43, takumif wrote:
> On 2016/11/11 17:59:52, apacible wrote:
> > How does this look for shorter custom controls?
> Uploaded screenshots:
>
https://drive.google.com/drive/folders/0BxrKSYHNwjQGbmVfMjZEcm5vdDQ?usp=sharing
> The bottom margin for the extensionview will be 2px smaller than it was before
> its top margin was increased.
Cool! One side note is it's typically easier to upload to screenshot/,
especially if drive settings change.

> > There was also some discussion about allowing the provider to send the
> necessary
> > height for the custom controls. What was the outcome of that discussion?
> I looked into it and it seemed that the host can tell the extensionview to
> change the size of the contents inside, but not the other way around.
We would have to plumb the desired height from the extension to the MR, likely
with the route info. We could have a minimum and maximum height that this value
has to fall through, so it's generally still the same size (not 10px vs 500px).
We could also have a default height in case the provider doesn't give us one.
WDYT?

[takumif, 2016-11-12 03:08:22]

On 2016/11/11 22:55:27, apacible wrote:
> On 2016/11/11 19:22:43, takumif wrote:
> > On 2016/11/11 17:59:52, apacible wrote:
> > > How does this look for shorter custom controls?
> > Uploaded screenshots:
> >
>
https://drive.google.com/drive/folders/0BxrKSYHNwjQGbmVfMjZEcm5vdDQ?usp=sharing
> > The bottom margin for the extensionview will be 2px smaller than it was
before
> > its top margin was increased.
> Cool! One side note is it's typically easier to upload to screenshot/,
> especially if drive settings change.
> 
> > > There was also some discussion about allowing the provider to send the
> > necessary
> > > height for the custom controls. What was the outcome of that discussion?
> > I looked into it and it seemed that the host can tell the extensionview to
> > change the size of the contents inside, but not the other way around.
> We would have to plumb the desired height from the extension to the MR, likely
> with the route info. We could have a minimum and maximum height that this
value
> has to fall through, so it's generally still the same size (not 10px vs
500px).
> We could also have a default height in case the provider doesn't give us one.
> WDYT?

I'm not sure if we want to plumb the height all the way from the component
extension to the dialog WebUI via MR (especially now that we're trying to
replace the extensionview with simple WebUI). To me it feels like a UI-specific
detail that shouldn't be passed through MR.

[apacible, 2016-11-12 03:57:45]

On 2016/11/12 03:08:22, takumif wrote:
> On 2016/11/11 22:55:27, apacible wrote:
> > On 2016/11/11 19:22:43, takumif wrote:
> > > On 2016/11/11 17:59:52, apacible wrote:
> > > > How does this look for shorter custom controls?
> > > Uploaded screenshots:
> > >
> >
>
https://drive.google.com/drive/folders/0BxrKSYHNwjQGbmVfMjZEcm5vdDQ?usp=sharing
> > > The bottom margin for the extensionview will be 2px smaller than it was
> before
> > > its top margin was increased.
> > Cool! One side note is it's typically easier to upload to screenshot/,
> > especially if drive settings change.
> > 
> > > > There was also some discussion about allowing the provider to send the
> > > necessary
> > > > height for the custom controls. What was the outcome of that discussion?
> > > I looked into it and it seemed that the host can tell the extensionview to
> > > change the size of the contents inside, but not the other way around.
> > We would have to plumb the desired height from the extension to the MR,
likely
> > with the route info. We could have a minimum and maximum height that this
> value
> > has to fall through, so it's generally still the same size (not 10px vs
> 500px).
> > We could also have a default height in case the provider doesn't give us
one.
> > WDYT?
> 
> I'm not sure if we want to plumb the height all the way from the component
> extension to the dialog WebUI via MR (especially now that we're trying to
> replace the extensionview with simple WebUI). To me it feels like a
UI-specific
> detail that shouldn't be passed through MR.

Sounds fair. lgtm

[takumif, 2016-11-14 18:49:57]

The CQ bit was checked by takumif@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 18:51:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[takumif, 2016-11-14 19:19:32]

Description was changed from

==========
[MR UI] Make custom controls / extensionview in the dialog taller by 6px

This change makes the custom controls taller, so that the custom controls for
YouTube, etc aren't clipped.

BUG=630294
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MR UI] Make custom controls / extensionview in the dialog taller by 6px

This change makes the custom controls taller, so that the custom controls for
YouTube, etc aren't clipped.

BUG=630294
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-11-14 20:06:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 20:06:05]

Dry run: This issue passed the CQ dry run.

[takumif, 2016-11-14 22:05:16]

The CQ bit was checked by takumif@chromium.org

[commit-bot: I haz the power, 2016-11-14 22:07:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 00:05:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 00:05:05]

Failed to apply patch for
chrome/browser/resources/media_router/elements/route_details/route_details.css:
While running git apply --index -p1;
  error: patch failed:
chrome/browser/resources/media_router/elements/route_details/route_details.css:5
  error:
chrome/browser/resources/media_router/elements/route_details/route_details.css:
patch does not apply

Patch:      
chrome/browser/resources/media_router/elements/route_details/route_details.css
Index:
chrome/browser/resources/media_router/elements/route_details/route_details.css
diff --git
a/chrome/browser/resources/media_router/elements/route_details/route_details.css
b/chrome/browser/resources/media_router/elements/route_details/route_details.css
index
eaff052bf5214887ffe9b467215f3c830e130e69..d2207455dee1ded70b2080981416232bbd520b69
100644
---
a/chrome/browser/resources/media_router/elements/route_details/route_details.css
+++
b/chrome/browser/resources/media_router/elements/route_details/route_details.css
@@ -5,7 +5,7 @@
 
 #custom-controller {
   display: inline-block;
-  height: 136px;
+  height: 142px;
   width: 100%;
 }

[commit-bot: I haz the power, 2016-11-15 00:07:24]

Description was changed from

==========
[MR UI] Make custom controls / extensionview in the dialog taller by 6px

This change makes the custom controls taller, so that the custom controls for
YouTube, etc aren't clipped.

BUG=630294
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MR UI] Make custom controls / extensionview in the dialog taller by 6px

This change makes the custom controls taller, so that the custom controls for
YouTube, etc aren't clipped.

BUG=630294
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/5cf820b69968e571dc962e04ec91750e69843134
Cr-Commit-Position: refs/heads/master@{#431998}
==========

[commit-bot: I haz the power, 2016-11-15 00:07:26]

Patchset 1 (id:??) landed as
https://crrev.com/5cf820b69968e571dc962e04ec91750e69843134
Cr-Commit-Position: refs/heads/master@{#431998}