Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2490003003: Remove gvr SDK dependency (Closed)

Created:
4 years, 1 month ago by bshe
Modified:
4 years, 1 month ago
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove gvr SDK dependency SDK is used to only get a string which only avaialble in SDK. A bug has filed to make the string available in NDK too. Before it fixed, we use a hard coded string to remove the SDK dependency. This should reduce the binary size since the proguard is configured to keep a lot of java functions. BUG=664145 Committed: https://crrev.com/c84c42ec3910d27eea80a9bef3db419339aff884 Cr-Commit-Position: refs/heads/master@{#431633}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -25 lines) Patch
M chrome/android/BUILD.gn View 1 2 chunks +2 lines, -8 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java View 1 3 chunks +5 lines, -12 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/gvr-android-sdk/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
bshe
Hi David. Do you mind to take a look at this CL? Thanks!
4 years, 1 month ago (2016-11-10 13:51:33 UTC) #4
David Trainor- moved to gerrit
lgtm
4 years, 1 month ago (2016-11-11 17:47:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2490003003/1
4 years, 1 month ago (2016-11-11 17:49:57 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/104199)
4 years, 1 month ago (2016-11-11 17:53:07 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2490003003/20001
4 years, 1 month ago (2016-11-11 19:37:40 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-11 20:46:02 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 21:00:35 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c84c42ec3910d27eea80a9bef3db419339aff884
Cr-Commit-Position: refs/heads/master@{#431633}

Powered by Google App Engine
This is Rietveld 408576698