Utility routines for ng_units

Utility routines for ng_units

In preparation for landing abspos there I few routines I needed.

BUG=635619
Committed: https://crrev.com/7ce5c104a12aaae9f91ea5cf2329e4fb21ab78ab
Cr-Commit-Position: refs/heads/master@{#431712}

[atotic, 2016-11-11 01:44:19]

Description was changed from

==========
Utility routines for ng_units

BUG=635619
==========

to

==========
Utility routines for ng_units

In preparation for landing abspos there I few routines I needed.

BUG=635619
==========

[atotic, 2016-11-11 01:44:19]

atotic@chromium.org changed reviewers:
+ cbiesinger@chromium.org, ikilpatrick@chromium.org

[atotic, 2016-11-11 04:28:28]

atotic@chromium.org changed reviewers:
+ eae@chromium.org

[cbiesinger, 2016-11-11 04:31:47]

https://codereview.chromium.org/2489953006/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/ng/ng_units.cc (right):

https://codereview.chromium.org/2489953006/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ng/ng_units.cc:11: LayoutUnit
MinAndMaxContentSizes::ShrinkToFit(LayoutUnit container_size) const {
Interesting idea to add this function as a member function here! I think I like
it.

container_size -> available_size. They're not quite the same because you need to
subtract margins for this to be correct.

Also please change ResolveInlineLength to use this function.

https://codereview.chromium.org/2489953006/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ng/ng_units.cc:147: TextDirection
direction) const {
This is equivalent to
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/ng...
right? Can you remove the old one?

[atotic, 2016-11-11 05:16:23]

Code fixes are in.

https://codereview.chromium.org/2489953006/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/ng/ng_units.cc (right):

https://codereview.chromium.org/2489953006/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ng/ng_units.cc:11: LayoutUnit
MinAndMaxContentSizes::ShrinkToFit(LayoutUnit container_size) const {
On 2016/11/11 at 04:31:47, cbiesinger wrote:
> Interesting idea to add this function as a member function here! I think I
like it.
> 
> container_size -> available_size. They're not quite the same because you need
to subtract margins for this to be correct.
> 
> Also please change ResolveInlineLength to use this function.

Done.

https://codereview.chromium.org/2489953006/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ng/ng_units.cc:147: TextDirection
direction) const {
On 2016/11/11 at 04:31:47, cbiesinger wrote:
> This is equivalent to
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/ng...
right? Can you remove the old one?

Oh man, I missed that one. Done, old one has been removed, and I cleaned up my
code a bit.

[atotic, 2016-11-11 17:37:32]

ptal

[cbiesinger, 2016-11-11 18:30:17]

lgtm

[atotic, 2016-11-11 19:50:03]

The CQ bit was checked by atotic@chromium.org

[commit-bot: I haz the power, 2016-11-11 19:50:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 20:28:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 20:28:14]

Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[atotic, 2016-11-11 21:27:13]

The CQ bit was checked by atotic@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 21:27:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-12 00:32:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-12 00:32:49]

Dry run: This issue passed the CQ dry run.

[atotic, 2016-11-12 00:34:32]

The CQ bit was checked by atotic@chromium.org

[atotic, 2016-11-12 00:34:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
cbiesinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2489953006/#ps40001
(title: "Added missing CORE_EXPORT")

[commit-bot: I haz the power, 2016-11-12 00:35:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-12 00:40:34]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-12 00:42:05]

Description was changed from

==========
Utility routines for ng_units

In preparation for landing abspos there I few routines I needed.

BUG=635619
==========

to

==========
Utility routines for ng_units

In preparation for landing abspos there I few routines I needed.

BUG=635619

Committed: https://crrev.com/7ce5c104a12aaae9f91ea5cf2329e4fb21ab78ab
Cr-Commit-Position: refs/heads/master@{#431712}
==========

[commit-bot: I haz the power, 2016-11-12 00:42:06]

Patchset 3 (id:??) landed as
https://crrev.com/7ce5c104a12aaae9f91ea5cf2329e4fb21ab78ab
Cr-Commit-Position: refs/heads/master@{#431712}