Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2489953003: Fix ARM and MIPS builds for gcc 4.9.2. (Closed)

Created:
4 years, 1 month ago by rmacnak
Modified:
4 years, 1 month ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -24 lines) Patch
M runtime/vm/assembler_arm_test.cc View 1 chunk +16 lines, -12 lines 0 comments Download
M runtime/vm/assembler_mips_test.cc View 1 chunk +16 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years, 1 month ago (2016-11-10 18:45:02 UTC) #2
zra
lgtm
4 years, 1 month ago (2016-11-10 18:46:54 UTC) #3
rmacnak
4 years, 1 month ago (2016-11-10 19:13:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e3f791b00ed86899779073dc69f8a3a0aa911486 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698