Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 2489943003: Revert of [Web Payments] Mojom namespace blink -> payments (Closed)

Created:
4 years, 1 month ago by Dirk Pranke
Modified:
4 years, 1 month ago
CC:
Aaron Boodman, abarth-chromium, blink-reviews, chromium-reviews, darin (slow to review), haraken, qsr+mojo_chromium.org, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Web Payments] Mojom namespace blink -> payments (patchset #5 id:80001 of https://codereview.chromium.org/2477883002/ ) Reason for revert: Looks like this broke some tests on at least Android: https://build.chromium.org/p/chromium.android/builders/Android%20N5X%20Swarm%20Builder/builds/6152 so I'm reverting this. Sorry! Original issue's description: > [Web Payments] Mojom namespace blink -> payments > > When we migrated payment_request.mojom from Blink to components/ > we left the namespace in place to minimize changes and facilitate > the move. This CL simply changes the namespace that the payment > request stuff resides in. Lots of files changed, little depth. > > BUG=659644 > > Committed: https://crrev.com/3a05ff5fc9fce479f12e3fbcdaaa9df88a7b7aa2 > Cr-Commit-Position: refs/heads/master@{#430990} TBR=mkwst@chromium.org,rouslan@chromium.org,krb@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=659644 Committed: https://crrev.com/90916b06da350459d3cc60a8d89ad2fe2b56c063 Cr-Commit-Position: refs/heads/master@{#431014}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -250 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/payments/android/payments_jni_registrar.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M components/payments/payment_details_validation.h View 1 chunk +1 line, -1 line 0 comments Download
M components/payments/payment_details_validation.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M components/payments/payment_request.mojom View 1 chunk +1 line, -1 line 0 comments Download
M components/payments/payments_validators.h View 1 chunk +1 line, -1 line 0 comments Download
M components/payments/payments_validators.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/payments/payments_validators_test.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M content/public/app/mojo/content_browser_manifest.json View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/AbortTest.cpp View 3 chunks +3 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/CompleteTest.cpp View 6 chunks +17 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/OnPaymentResponseTest.cpp View 29 chunks +110 lines, -116 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentAddress.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentAddress.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentAddressTest.cpp View 3 chunks +3 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequest.h View 3 chunks +7 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequest.cpp View 10 chunks +32 lines, -34 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp View 6 chunks +10 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentResponse.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentResponse.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentResponseTest.cpp View 5 chunks +6 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentTestHelper.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentTestHelper.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentsValidators.h View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentsValidators.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentsValidatorsTest.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Dirk Pranke
Created Revert of [Web Payments] Mojom namespace blink -> payments
4 years, 1 month ago (2016-11-09 19:47:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2489943003/1
4 years, 1 month ago (2016-11-09 19:47:53 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-09 19:49:10 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 19:59:14 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/90916b06da350459d3cc60a8d89ad2fe2b56c063
Cr-Commit-Position: refs/heads/master@{#431014}

Powered by Google App Engine
This is Rietveld 408576698