Issue 2489933002: [heap] Fix -Wsign-compare warnings

Issue 2489933002: [heap] Fix -Wsign-compare warnings (Closed)

Created:
4 years, 1 month ago by ulan

Modified:
4 years, 1 month ago

Reviewers:
Michael Lippautz

CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

[heap] Fix -Wsign-compare warnings BUG=v8:5614 Committed: https://crrev.com/ade3bc6da99610e3c137df798bd10d36589df52d Cr-Commit-Position: refs/heads/master@{#40880}

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -19 lines)			Patch
M	src/heap/mark-compact.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/heap/spaces.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/heap/spaces.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/heap/heap-utils.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	test/cctest/heap/test-heap.cc	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	test/cctest/heap/test-spaces.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	test/unittests/heap/marking-unittest.cc	View		3 chunks	+7 lines, -7 lines	0 comments	Download
M	test/unittests/heap/slot-set-unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 13 (8 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2489933002/20001

4 years, 1 month ago (2016-11-10 09:45:04 UTC) #10

commit-bot: I haz the power

4 years, 1 month ago (2016-11-17 22:28:28 UTC) #13

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/ade3bc6da99610e3c137df798bd10d36589df52d
Cr-Commit-Position: refs/heads/master@{#40880}