Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 2489903002: Disables tooltip tests for aura-mus-client (Closed)

Created:
4 years, 1 month ago by sky
Modified:
4 years, 1 month ago
Reviewers:
msw
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disables tooltip tests for aura-mus-client These tests use AuraTestHelper::GetContext(), which doesn't make sense for aura-mus-client. The reason GetContext() doesn't make sense is that GetContext() is created by AuraTestHelper from a WindowTreeHost and is generally used to corresponds to the root of an ash environment where you use NativeWidgetAura. This only makes sense for the aura-mus-windowmanager config. So, I'm making these early out for now and we'll have to reevaluate them later. BUG=663781 TEST=test only change R=msw@chromium.org Committed: https://crrev.com/ce4cfbd771f398405d2985095f9d4774aa0a04f6 Cr-Commit-Position: refs/heads/master@{#430982}

Patch Set 1 #

Patch Set 2 : tweak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -17 lines) Patch
M ui/views/corewm/tooltip_controller_unittest.cc View 1 16 chunks +88 lines, -16 lines 0 comments Download
M ui/views/mus/views_aura_mus_test_suite.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/test/platform_test_helper.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/test/platform_test_helper.cc View 2 chunks +11 lines, -0 lines 0 comments Download
M ui/views/test/views_test_base.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/test/views_test_base.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
sky
4 years, 1 month ago (2016-11-09 17:35:25 UTC) #1
msw
lgtm
4 years, 1 month ago (2016-11-09 17:52:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2489903002/20001
4 years, 1 month ago (2016-11-09 17:56:13 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-09 18:25:28 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 18:46:57 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ce4cfbd771f398405d2985095f9d4774aa0a04f6
Cr-Commit-Position: refs/heads/master@{#430982}

Powered by Google App Engine
This is Rietveld 408576698