[net/auth] Discard current handler token generation fails.

net/http/http_auth_controller.cc

Index: net/http/http_auth_controller.cc
diff --git a/net/http/http_auth_controller.cc b/net/http/http_auth_controller.cc
index 78e5a0354beec639b911260a6b9621ba2aeeb727..5e614e533ab5605c047dd08ecb422a8c268fcc88 100644
--- a/net/http/http_auth_controller.cc
+++ b/net/http/http_auth_controller.cc
@@ -483,6 +483,7 @@ int HttpAuthController::HandleGenerateTokenResult(int result) {
       //
       // If the handler does not support any remaining identity sources, then

[mmenke, 2016/11/14 18:03:49]

"The handler" seems incorrect here, since we're destroying it.

[asanka, 2016/11/14 18:49:52]

DOne.

       // the authentication controller will pick another authentication handler.
+      InvalidateCurrentHandler(INVALIDATE_HANDLER_AND_CACHED_CREDENTIALS);
       auth_token_.clear();
       return OK;
 
@@ -503,7 +504,7 @@ int HttpAuthController::HandleGenerateTokenResult(int result) {
 
       // In these cases, disable the current scheme as it cannot
       // succeed.
-      DisableAuthScheme(handler_->auth_scheme());
+      InvalidateCurrentHandler(INVALIDATE_HANDLER_AND_DISABLE_SCHEME);

[mmenke, 2016/11/14 18:03:49]

None of the new tests exercise this, do they?

[asanka, 2016/11/14 18:49:53]

Not the new tests. But existing tests in the GenerateAuthToken suite do. You can
find them by searching the test cases for ERR_UNSUPPORTED_AUTH_SCHEME.

       auth_token_.clear();
       return OK;