Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 2489883002: [headless] Fix relative path in client_api_generator. (Closed)

Created:
4 years, 1 month ago by Eric Seckler
Modified:
4 years, 1 month ago
Reviewers:
Sami
CC:
chromium-reviews, pfeldman, devtools-reviews_chromium.org, altimin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[headless] Fix relative path in client_api_generator. Build is broken since https://codereview.chromium.org/2473073003/. BUG=546953 Committed: https://crrev.com/f4509fa0548726806b4e56fe2e40d7962239c385 Cr-Commit-Position: refs/heads/master@{#430949}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M headless/lib/browser/devtools_api/client_api_generator.py View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Eric Seckler
4 years, 1 month ago (2016-11-09 16:22:53 UTC) #2
Sami
lgtm, thanks for the fix!
4 years, 1 month ago (2016-11-09 16:33:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2489883002/1
4 years, 1 month ago (2016-11-09 16:34:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-09 16:43:13 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 16:45:08 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f4509fa0548726806b4e56fe2e40d7962239c385
Cr-Commit-Position: refs/heads/master@{#430949}

Powered by Google App Engine
This is Rietveld 408576698