extensions/browser/api/system_display/system_display_apitest.cc - Issue 2489873002: Change GetAllDisplays() in all screens to return a const vector&.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/system_display/system_display_apitest.cc

Issue 2489873002: Change GetAllDisplays() in all screens to return a const vector&. (Closed)

Patch Set: roll back to rebase as dummy_screen_android is reverted Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/system_display/system_display_apitest.cc

diff --git a/extensions/browser/api/system_display/system_display_apitest.cc b/extensions/browser/api/system_display/system_display_apitest.cc

index deeb22946080ade2963ecb95004e99156f332142..36943530e17b344622544ed17827c4193e2ae1c3 100644

--- a/extensions/browser/api/system_display/system_display_apitest.cc

+++ b/extensions/browser/api/system_display/system_display_apitest.cc

@@ -47,7 +47,7 @@ class MockScreen : public Screen {

int GetNumDisplays() const override {

return static_cast<int>(displays_.size());

}

- std::vector<display::Display> GetAllDisplays() const override {

+ const std::vector<display::Display>& GetAllDisplays() const override {

return displays_;

}

display::Display GetDisplayNearestWindow(