Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2489863003: [compiler,modules] Introduce JS operators for module loads and stores. (Closed)

Created:
4 years, 1 month ago by neis
Modified:
4 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, rmcilroy, adamk
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler,modules] Introduce JS operators for module loads and stores. With this CL, the bytecode graph builder no longer translates module loads/stores as runtime calls but in terms of two new JS operators. These are lowered in typed-lowering to a sequence of LoadField's. R=bmeurer@chromium.org CC=adamk@chromium.org BUG=v8:1569 Committed: https://crrev.com/a9f593ef6ba936f07c034ce74e93a1bd9507df5f Cr-Commit-Position: refs/heads/master@{#40881}

Patch Set 1 #

Patch Set 2 : Remove unused variable. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -12 lines) Patch
M src/compiler/access-builder.h View 2 chunks +9 lines, -0 lines 0 comments Download
M src/compiler/access-builder.cc View 2 chunks +29 lines, -0 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 1 chunk +13 lines, -12 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/compiler/js-operator.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/js-operator.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 3 chunks +80 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
neis
4 years, 1 month ago (2016-11-10 09:11:38 UTC) #1
Benedikt Meurer
As per offline discussion, this is LGTM.
4 years, 1 month ago (2016-11-10 09:43:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2489863003/1
4 years, 1 month ago (2016-11-10 09:45:03 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/builds/7636)
4 years, 1 month ago (2016-11-10 09:50:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2489863003/20001
4 years, 1 month ago (2016-11-10 09:54:23 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-10 10:21:10 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:28:35 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a9f593ef6ba936f07c034ce74e93a1bd9507df5f
Cr-Commit-Position: refs/heads/master@{#40881}

Powered by Google App Engine
This is Rietveld 408576698