Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Unified Diff: components/metrics/drive_metrics_provider_linux.cc

Issue 2489853002: Added function to provide the short board name of the device (Closed)
Patch Set: Fixed the review comment Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/sys_info.h ('K') | « base/sys_info_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/metrics/drive_metrics_provider_linux.cc
diff --git a/components/metrics/drive_metrics_provider_linux.cc b/components/metrics/drive_metrics_provider_linux.cc
index 35c505a3492b945e814f7f4861f61478bf7c43a3..827374790bf14f44765c33b21fbdd8dec0b0a428 100644
--- a/components/metrics/drive_metrics_provider_linux.cc
+++ b/components/metrics/drive_metrics_provider_linux.cc
@@ -33,7 +33,7 @@ const char kRotationalFormat[] = "/sys/block/sd%c/queue/rotational";
bool DriveMetricsProvider::HasSeekPenalty(const base::FilePath& path,
bool* has_seek_penalty) {
#if defined(OS_CHROMEOS)
Thiemo Nagel 2016/11/23 20:21:19 There's parrot, parrot_ivb and parrot_freon. Whic
Dan Beam 2016/11/23 21:18:37 ¯\_(ツ)_/¯ maybe use StartsWith()?
igorcov 2016/11/25 11:08:59 Done.
- std::string board = base::SysInfo::GetLsbReleaseBoard();
+ std::string board = base::SysInfo::GetStrippedReleaseBoard();
if (board != "unknown" && board != "parrot") {
// All ChromeOS devices have SSDs. Except some parrots.
*has_seek_penalty = false;
« base/sys_info.h ('K') | « base/sys_info_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698